521238 – net-irc/quassel-0.10.0-r1 should RDEPEND on sys-libs/zlib

Bug 521238 - net-irc/quassel-0.10.0-r1 should RDEPEND on sys-libs/zlib

Summary: net-irc/quassel-0.10.0-r1 should RDEPEND on sys-libs/zlib

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Patrick Lauer

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2014-08-27 08:49 UTC by Nikoli
Modified:	2014-09-13 15:32 UTC (History)
CC List:	4 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Nikoli 2014-08-27 08:49:51 UTC

$ objdump -p /usr/bin/quasselcore |grep NEEDED|grep z
  NEEDED               libz.so.1
$ objdump -p /usr/bin/quasselclient |grep NEEDED|grep z
  NEEDED               libz.so.1

quassel-0.10.0 $ grep zlib CMakeLists.txt -i -A5
# zlib for compression, however we can always fall back to miniz
find_package(ZLIB)
if(ZLIB_FOUND)
  message(STATUS "Using system zlib for compression")
  add_definitions(-DHAVE_ZLIB)
  include_directories(${ZLIB_INCLUDE_DIRS})
  set(COMMON_LIBRARIES ${COMMON_LIBRARIES} ${ZLIB_LIBRARIES})
else()
  message(STATUS "zlib NOT found, using bundled miniz for compression")
  if(${CMAKE_SIZEOF_VOID_P} EQUAL 4)
    message(STATUS "WARNING: This may be slow on 32 bit systems!")
  endif()
endif()


sputnick, does it matter if system zlib copy is compiled with minizip enabled or disabled?

Comment 1 Johannes Huber (RETIRED) gentoo-dev

2014-09-13 15:32:57 UTC

Thanks for reporting. This is fixed in cvs now. Please sync in some hours to get the change.

+
+  13 Sep 2014; Johannes Huber <johu@gentoo.org> quassel-0.10.0-r1.ebuild:
+  RDEPEND on sys-libs/zlib, bug #521238.
+