Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 520684 - sys-fs/eudev-1.10 - .../work/eudev-1.10/src/shared/label.c:94:36: error: array type has incomplete element type
Summary: sys-fs/eudev-1.10 - .../work/eudev-1.10/src/shared/label.c:94:36: error: arra...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: eudev team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-23 10:45 UTC by Alpha Bravo
Modified: 2014-09-03 11:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (file_520684.txt,2 bytes, text/plain)
2014-08-23 10:49 UTC, Alpha Bravo
Details
build.log (build.log,27.79 KB, text/plain)
2014-08-23 20:24 UTC, Alpha Bravo
Details
patch including selinux headers (0001-fix-SELINUX-build.patch,788 bytes, patch)
2014-09-02 19:21 UTC, Amadeusz Sławiński
Details | Diff
patch linking libudev against SELINUX (0001-link-libudev-against-SELINUX.patch,919 bytes, patch)
2014-09-03 09:04 UTC, Amadeusz Sławiński
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alpha Bravo 2014-08-23 10:45:07 UTC
upgrading eudev-1.9-r2 to eudev-1.10, eudev-1.10 fails to build

# emerge -pqv eudev
[ebuild     U ] sys-fs/eudev-1.10 [1.9-r2] USE="gudev hwdb keymap kmod openrc (selinux) -doc -introspection -modutils -rule-generator -static-libs {-test}" ABI_X86="(64) -32 (-x32)" 

Reproducible: Always

Steps to Reproduce:
emerge -1v eudev
Actual Results:  
Makefile:514: recipe for target 'label.lo' failed
[...]
make: *** [all] Error 2
 * ERROR: sys-fs/eudev-1.10::gentoo failed (compile phase):
 *   emake failed


# emerge --info
Portage 2.2.12 (python 3.3.5-final-0, hardened/linux/amd64/selinux, gcc-4.8.3, glibc-2.19-r1, 3.15.10-hardened-r1 x86_64)
=================================================================
System uname: Linux-3.15.10-hardened-r1-x86_64-AMD_E-350_Processor-with-gentoo-2.2
KiB Mem:     3634636 total,   2213940 free
KiB Swap:    4718588 total,   4718588 free
Timestamp of tree: Sat, 23 Aug 2014 09:15:01 +0000
ld GNU ld (Gentoo 2.24 p1.4) 2.24
app-shells/bash:          4.2_p47
dev-lang/python:          2.7.8, 3.3.5-r1, 3.4.1
dev-util/cmake:           2.8.12.2-r2
dev-util/pkgconfig:       0.28-r2
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.13.1
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.69
sys-devel/automake:       1.14.1
sys-devel/binutils:       2.24-r3
sys-devel/gcc:            4.8.3
sys-devel/gcc-config:     1.8
sys-devel/libtool:        2.4.2-r1
sys-devel/make:           4.0-r1
sys-kernel/linux-headers: 3.16 (virtual/os-headers)
sys-libs/glibc:           2.19-r1
Repositories: gentoo qt hce-overlay
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=btver1 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=btver1 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox selinux sesandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://ftp.spline.inf.fu-berlin.de/mirrors/gentoo/ ftp://ftp.spline.inf.fu-berlin.de/mirrors/gentoo/ rsync://ftp.halifax.rwth-aachen.de/gentoo/"
INSTALL_MASK="/lib/systemd /lib32/systemd /lib64/systemd /usr/lib/systemd /usr/lib32/systemd /usr/lib64/systemd /etc/systemd"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/qt /home/corse/ebuilds"
SYNC="rsync://rsync.cn.gentoo.org/gentoo-portage/"
USE="X aac acl alsa amd64 berkdb bindist bzip2 cli cracklib crypt cxx dbus dri gdbm hardened iconv ipv6 jpeg justify mmx mmxext modules mp3 multilib ncurses nls nptl open_perms opengl openmp pam pax_kernel pcre readline sdl selinux session sse sse2 sse3 ssl ssse3 tcpd theora udev unconfined unicode urandom vdpau vorbis x264 xattr xtpax xv zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3 python3_4" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="radeon r600" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Alpha Bravo 2014-08-23 10:49:00 UTC
Created attachment 383450 [details]
build.log
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2014-08-23 13:45:07 UTC
Comment on attachment 383450 [details]
build.log

Please attach the entire build log to this bug report.
Comment 3 Alpha Bravo 2014-08-23 20:24:27 UTC
Created attachment 383482 [details]
build.log
Comment 4 Amadeusz Sławiński 2014-09-02 19:21:41 UTC
Created attachment 384130 [details, diff]
patch including selinux headers

Seems like headers were removed in https://github.com/gentoo/eudev/commit/03070edd5c0f6ae55ed79b9fc1295af39844ff40
Comment 5 Anthony Basile gentoo-dev 2014-09-02 21:28:08 UTC
(In reply to Amadeusz Sławiński from comment #4)
> Created attachment 384130 [details, diff] [details, diff]
> patch including selinux headers
> 
> Seems like headers were removed in
> https://github.com/gentoo/eudev/commit/
> 03070edd5c0f6ae55ed79b9fc1295af39844ff40

Yes thanks!  This was the result of the massive refactoring of code.
Comment 6 Anthony Basile gentoo-dev 2014-09-02 22:36:08 UTC
(In reply to Anthony Basile from comment #5)
> (In reply to Amadeusz Sławiński from comment #4)
> > Created attachment 384130 [details, diff] [details, diff] [details, diff]
> > patch including selinux headers
> > 
> > Seems like headers were removed in
> > https://github.com/gentoo/eudev/commit/
> > 03070edd5c0f6ae55ed79b9fc1295af39844ff40
> 
> Yes thanks!  This was the result of the massive refactoring of code.

Okay I've pushed the patch upstream and added it to the tree.  Please test eudev-1.10.ebuild again.  Since this is a compile failure for USE=selinux, I did not rev bump.

Reopn if this is still an issue.
Comment 7 Alpha Bravo 2014-09-03 04:15:47 UTC
builds fine here, thanks!
Comment 8 Amadeusz Sławiński 2014-09-03 08:44:27 UTC
It also builds fine here and starts system

but noticed that X has problems

/usr/bin/X: symbol lookup error: /lib64/libudev.so.1: undefined symbol: is_selinux_enabled

When trying to reemerge xorg-server it also fails while linking to libudev
/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.0/../../../../lib64/libudev.so: undefined reference to `security_getenforce'
/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.0/../../../../lib64/libudev.so: undefined reference to `selabel_close'
/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.0/../../../../lib64/libudev.so: undefined reference to `lsetfilecon'
/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.0/../../../../lib64/libudev.so: undefined reference to `selabel_lookup_raw'
/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.0/../../../../lib64/libudev.so: undefined reference to `freecon'
/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.0/../../../../lib64/libudev.so: undefined reference to `is_selinux_enabled'
/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.0/../../../../lib64/libudev.so: undefined reference to `setfilecon'
/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.0/../../../../lib64/libudev.so: undefined reference to `selabel_open'
/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.0/../../../../lib64/libudev.so: undefined reference to `setfscreatecon'
collect2: error: ld returned 1 exit status

Seems to be caused by libudev not linking against selinux, but not sure at which step it fails to add it.
Comment 9 Amadeusz Sławiński 2014-09-03 09:04:11 UTC
Created attachment 384150 [details, diff]
patch linking libudev against SELINUX

Ok, found it, seems like when it was refactored not all linking was taken into account.

I added SELINUX_LIBS, but someone might want to check if there is some more things needed, though it didn't report any missing symbols this time when starting X so maybe not.
Comment 10 Anthony Basile gentoo-dev 2014-09-03 11:01:11 UTC
(In reply to Amadeusz Sławiński from comment #9)
> Created attachment 384150 [details, diff] [details, diff]
> patch linking libudev against SELINUX
> 
> Ok, found it, seems like when it was refactored not all linking was taken
> into account.
> 
> I added SELINUX_LIBS, but someone might want to check if there is some more
> things needed, though it didn't report any missing symbols this time when
> starting X so maybe not.

This is definitely needed, and probably sufficient.  I pushed upstream and added it to the tree with a rev bump.  Please test eudev-1.10-r1.