Created attachment 382752 [details] kwave-0.8.12 ebuild Hi, I have seen that the kwave version in portage is quite out of date (0.8.10). Some weeks ago I released Kwave v0.8.12 - please update! BTW: please note the ebuild update (see attachment), it contains spanish language and updated cmake invocation regards, Thomas
Comment on attachment 382752 [details] kwave-0.8.12 ebuild Not a patch. Contains CVS header and stable keywords.
Created attachment 382852 [details, diff] ebuild patch
Of course this is not a patch, I never said that. If you want a patch - here it is!
Comment on attachment 382852 [details, diff] ebuild patch >--- kwave-0.8.10.ebuild 2013-12-16 19:01:23.000000000 +0100 >+++ kwave-0.8.12.ebuild 2014-08-13 20:46:31.130422381 +0200 >@@ -4,8 +4,8 @@ >-KEYWORDS="amd64 x86" >+KEYWORDS="amd64 ~ppc x86" We don't add stable keywords and ~ppc has to be added by ppc arch team. >- media-libs/audiofile:= >+ media-libs/audiofile Why removing slot operator? >- -DWITH_SAMPLERATE=ON >- $(cmake-utils_use_with alsa) >- $(cmake-utils_use_with flac) >- $(cmake-utils_use_with mp3) >+ $(cmake-utils_use_with alsa ALSA) >+ $(cmake-utils_use_with handbook DOC) >+ $(cmake-utils_use_with flac FLAC) >+ $(cmake-utils_use_with mp3 MP3) > $(cmake-utils_use_with vorbis OGG_VORBIS) > $(cmake-utils_use_with opus OGG_OPUS) >- $(cmake-utils_use_with oss) >- $(cmake-utils_use_with phonon) >- $(cmake-utils_use_with pulseaudio) >- $(cmake-utils_use debug) >+ $(cmake-utils_use_with oss OSS) >+ $(cmake-utils_use_with phonon PHONON) >+ $(cmake-utils_use_with pulseaudio PULSEAUDIO) >+ $(cmake-utils_use debug DEBUG) If use flag is named identical to the build option, there is no need to uppercase it. See cmake-utils.eclass for details.
(In reply to Johannes Huber from comment #4) > Comment on attachment 382852 [details, diff] [details, diff] > [...] > >- media-libs/audiofile:= > >+ media-libs/audiofile > > Why removing slot operator? Is that really required? I never felt the need for it, I use just the latest version of it, no matter which slot it is in. But if you think so, ok... > [...] > >- $(cmake-utils_use_with alsa) > [...] > >+ $(cmake-utils_use_with alsa ALSA) > [...] > If use flag is named identical to the build option, there is no need to > uppercase it. See cmake-utils.eclass for details. Does it do any harm to do so? I tried both versions and made a diff between the two versions of the output. I can confirm that both work practically the same, but I prefer the explicit definition of the cmake flags, because it produces a cleaner cmake command line. The auto detection produces some "garbage" definitions that are not needed (e.g. -DWITH_alsa=ON -DWITH_Alsa=ON).
(In reply to Thomas from comment #5) > Is that really required? I never felt the need for it, I use just the latest > version of it, no matter which slot it is in. But if you think so, ok... Slot operators is used by portage to rebuild the package automatically if abi breaks. > Does it do any harm to do so? I tried both versions and made a diff between > the two versions of the output. I can confirm that both work practically the > same, but I prefer the explicit definition of the cmake flags, because it > produces a cleaner cmake command line. The auto detection produces some > "garbage" definitions that are not needed (e.g. -DWITH_alsa=ON > -DWITH_Alsa=ON). But it makes the ebuild more readable. I will bump it without the those changes or do you want to create a new patch?
Ok, then please go ahead! The most important changes against the ebuild of v0.8.10 were that KDE_LINGUAS now also contains spanish (es) and -DWITH_SAMPLERATE=ON is removed from the cmake flags (no longer needed), this should be fine. I will take over your suggestions into the next release. thanks, Thomas
Thanks for reporting. This is fixed in cvs now. Please sync in some hours to get the changes. + + 19 Aug 2014; Johannes Huber <johu@gentoo.org> +kwave-0.8.12.ebuild: + Version bump by Thomas Eschenbacher <Thomas.Eschenbacher@gmx.de>, bug #519726. +
