Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 517528 - net-proxy/dante-1.4.0-r1 - tostring.c: In function 'signal2string': tostring.c:1445:7: error: duplicate case value
Summary: net-proxy/dante-1.4.0-r1 - tostring.c: In function 'signal2string': tostring....
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: Alpha Linux
: Normal normal (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords: NeedPatch
Depends on:
Blocks: 506794
  Show dependency tree
 
Reported: 2014-07-19 19:58 UTC by Tobias Klausmann (RETIRED)
Modified: 2023-06-15 16:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
net-proxy/dante-1.4.0-r1 build log (build.log,74.80 KB, text/plain)
2014-07-19 20:00 UTC, Tobias Klausmann (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Klausmann (RETIRED) gentoo-dev 2014-07-19 19:58:43 UTC
/bin/sh ../libtool  --tag=CC   --mode=compile alpha-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I../include -I../libscompat  -D_XOPEN_SOURCE=600 -D_XOPEN_SOURCE_EXTENDED -D_BSD_SOURCE -DDEBUG=0 -DSOCKS_CLIENT=1 -DSOCKS_SERVER=0 -DSOCKSLIBRARY_DYNAMIC=0 -DSTANDALONE_UNIT_TEST=0 -mieee -pipe -O2 -mcpu=ev67 -g -O2 -ggdb -pipe  -c -o tostring.lo tostring.c
libtool: compile:  alpha-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I../include -I../libscompat -D_XOPEN_SOURCE=600 -D_XOPEN_SOURCE_EXTENDED -D_BSD_SOURCE -DDEBUG=0 -DSOCKS_CLIENT=1 -DSOCKS_SERVER=0 -DSOCKSLIBRARY_DYNAMIC=0 -DSTANDALONE_UNIT_TEST=0 -mieee -pipe -O2 -mcpu=ev67 -g -O2 -ggdb -pipe -c tostring.c  -fPIC -DPIC -o .libs/tostring.o
tostring.c: In function 'signal2string':
tostring.c:1445:7: error: duplicate case value
tostring.c:1385:7: error: previously used here
make[1]: *** [tostring.lo] Error 1
make[1]: Leaving directory `/var/tmp/portage/net-proxy/dante-1.4.0-r1/work/dante-1.4.0/lib'
make: *** [all-recursive] Error 1
 * ERROR: net-proxy/dante-1.4.0-r1::gentoo failed (compile phase):
 *   emake failed
 * 
 * If you need support, post the output of `emerge --info '=net-proxy/dante-1.4.0-r1::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=net-proxy/dante-1.4.0-r1::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/net-proxy/dante-1.4.0-r1/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/net-proxy/dante-1.4.0-r1/temp/environment'.
 * Working directory: '/var/tmp/portage/net-proxy/dante-1.4.0-r1/work/dante-1.4.0'
 * S: '/var/tmp/portage/net-proxy/dante-1.4.0-r1/work/dante-1.4.0'

>>> Failed to emerge net-proxy/dante-1.4.0-r1, Log file:

>>>  '/var/tmp/portage/net-proxy/dante-1.4.0-r1/temp/build.log'


Portage 2.2.8-r1 (default/linux/alpha/13.0, gcc-4.7.3, glibc-2.17, 3.11.9 alpha)=================================================================
System uname: Linux-3.11.9-alpha-EV68AL-with-gentoo-2.2
KiB Mem:     3918320 total,   2618072 free
KiB Swap:          0 total,         0 free
Timestamp of tree: Sat, 19 Jul 2014 17:00:01 +0000
ld GNU ld (Gentoo 2.23.2 p1.0) 2.23.2
app-shells/bash:          4.2_p45
dev-lang/python:          2.7.6, 3.3.3
dev-util/cmake:           2.8.12.2
dev-util/pkgconfig:       0.28
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.12.4
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.13.4
sys-devel/binutils:       2.23.2
sys-devel/gcc:            4.7.3-r1
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.13 (virtual/os-headers)
sys-libs/glibc:           2.17
Repositories: gentoo
ACCEPT_KEYWORDS="alpha"
ACCEPT_LICENSE="*"
CBUILD="alpha-unknown-linux-gnu"
CFLAGS="-mieee -pipe -O2 -mcpu=ev67"
CHOST="alpha-unknown-linux-gnu"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"CXXFLAGS="-mieee -pipe -O2 -mcpu=ev67"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs buildpkg config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://mirror.switch.ch/ftp/mirror/gentoo/"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
USE="acl alpha berkdb bzip2 cli cracklib crypt cxx dri fortran gdbm iconv ipv6 modules ncurses nls nptl pam pcre python readline session ssl tcpd unicode zlib" ALSA_CARDS="ali5451 als4000 bt87x ca0106 cmipci emu10k1 ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 maestro3 trident usb-audio via82xx ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="mga" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, MAKEOPTS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC
Comment 1 Tobias Klausmann (RETIRED) gentoo-dev 2014-07-19 20:00:00 UTC
Created attachment 381070 [details]
net-proxy/dante-1.4.0-r1 build log
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2014-09-08 11:45:13 UTC
try 1.4.1, it has some build fixes for various arches, OSes, ...
Comment 3 Tobias Klausmann (RETIRED) gentoo-dev 2014-09-08 15:49:17 UTC
I copied dante-1.4.0-r2.ebuild to dante-1.4.1.ebuild and did a manifest&&compile and it still fails in exactly the same way:

tostring.c: In function ‘signal2string’:
tostring.c:1555:7: error: duplicate case value
tostring.c:1495:7: error: previously used here


Note the two code locations:

#ifdef SIGINFO
  case SIGINFO:
    return "SIGINFO";
#endif /* SIGINFO */

vs.

#ifdef SIGPWR
  case SIGPWR:
    return "SIGPWR";
#endif /* SIGPWR */

Signals on Alpha are _not_ the same as on, say, amd64. On Alpha, USR1/USR2 are 30/31 (10/11 on amd64), SIGBUS is 10 (7 on amd64), ... there are more than that and I am not sure what the reasons are.

Thing is, Dante's detection of these flag values is broken on Alpha.
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2014-09-08 18:17:49 UTC
So you deal with it as it is dealt with elsewhere in the same file:

--- lib/tostring.c.orig 2014-08-21 18:21:50.000000000 +0200
+++ lib/tostring.c      2014-09-08 20:16:46.388500364 +0200
@@ -1551,7 +1551,7 @@
          return "SIGPROF";
 #endif /* SIGPROF */

-#ifdef SIGPWR
+#if (defined SIGPWR) && SIGPWR != SIGINFO
       case SIGPWR:
          return "SIGPWR";
 #endif /* SIGPWR */


Any more of those should be treated the same way.
Comment 5 Tobias Klausmann (RETIRED) gentoo-dev 2014-09-09 07:19:58 UTC
(In reply to Jeroen Roovers from comment #4)
> So you deal with it as it is dealt with elsewhere in the same file:

Yes, this makes it compile. But I am not sure if that doesn't break the logic elswhere.

Either way, adding (or not) the patch and sending it upstream is something for the maintainer to do.
Comment 6 Tobias Klausmann (RETIRED) gentoo-dev 2014-09-09 07:27:32 UTC
Scratch that. While tostring.c now compiles, I get more compilation errors:

alpha-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I../include -I../libscompat -I../lib  -D_XOPEN_SOURCE=600 -D_XOPEN_SOURCE_EXTENDED -D_BSD_SOURCE -DDEBUG=0 -DSOCKS_SERVER=1 -DSOCKS_CLIENT=0 -DSOCKSLIBRARY_DYNAMIC=1 -DSTANDALONE_UNIT_TEST=0 -mieee -pipe -O2 -mcpu=ev67 -g -O2 -ggdb -pipe  -c sockd_io.c
sockd_io.c: In function ‘siginfo’:
sockd_io.c:2921:5: error: missing binary operator before token "int"
sockd_io.c:2969:27: error: missing binary operator before token "int"
sockd_io.c:2996:5: error: missing binary operator before token "int"
sockd_io.c:3014:5: error: missing binary operator before token "int"
sockd_io.c:3035:7: error: missing binary operator before token "int"
sockd_io.c:3050:8: error: missing binary operator before token "int"
make[1]: *** [sockd_io.o] Error 1
make[1]: Leaving directory `/var/tmp/portage/net-proxy/dante-1.4.1/work/dante-1.4.1/sockd'
make: *** [all-recursive] Error 1

All of those seem to be preprocessor statement, for example (line 2921):

#if HAVE_SENDBUF_IOCTL
         int src_so_sndbuf, dst_so_sndbuf;
#endif /* HAVE_SENDBUF_IOCTL */
Comment 7 Pacho Ramos gentoo-dev 2015-07-28 18:58:42 UTC
Also fails on sparc
Comment 8 Pacho Ramos gentoo-dev 2016-05-06 10:50:20 UTC
Maybe other option would be to drop the stable keywords for alpha and sparc :/
Comment 9 Pacho Ramos gentoo-dev 2016-10-08 13:02:33 UTC
Does this patch from Debian fix it?
https://gitlab.com/dante/pkg-debian-full/raw/master/debian/patches/22-sigpwr-siginfo.patch
Comment 10 Tobias Klausmann (RETIRED) gentoo-dev 2016-10-22 12:34:29 UTC
(In reply to Pacho Ramos from comment #9)
> Does this patch from Debian fix it?
> https://gitlab.com/dante/pkg-debian-full/raw/master/debian/patches/22-sigpwr-
> siginfo.patch

Yes, this makes dante-1.4.0-r2 compile on Alpha, including USE=test (which doesn't seem to do very much, but still...).

I also tried with 1.4.1 (patch applies cleanly) and that, too compiles/tests now.
Comment 11 Pacho Ramos gentoo-dev 2016-10-24 12:53:51 UTC
[master 6531266] net-proxy/dante: Apply Debian patch to fix compilation on alpha and other arches (#517528 by Tobias Klausmann), apply opensuse patch to fix compilation with newer miniupnpc (#564680 by Rion), use proper configure option (#596198 by Xiami).
 3 files changed, 146 insertions(+)
 create mode 100644 net-proxy/dante/dante-1.4.1-r1.ebuild
 create mode 100644 net-proxy/dante/files/dante-1.4.1-miniupnp14.patch
 create mode 100644 net-proxy/dante/files/dante-1.4.1-sigpwr-siginfo.patch