Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 517442 - media-libs/freetype fix media-libs/harfbuzz dep, unmask USE harfbuzz
Summary: media-libs/freetype fix media-libs/harfbuzz dep, unmask USE harfbuzz
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ben de Groot (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 513718
  Show dependency tree
 
Reported: 2014-07-18 19:58 UTC by Nikoli
Modified: 2014-12-13 10:56 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikoli 2014-07-18 19:58:18 UTC 
profiles/base/package.use.mask:
# Ben de Groot <yngwin@gentoo.org> (21 Mar 2014)
# harfbuzz multilib ebuild is still masked
media-libs/freetype harfbuzz

No harfbuzz ebuilds are now masked for any profile:
$ grep media-libs/harfbuzz -R profiles/*|grep mask
profiles/arch/amd64/package.use.stable.mask:media-libs/harfbuzz abi_x86_32
Comment 1 Rafał Mużyło 2014-07-18 20:06:52 UTC 
...IIRC there was at least one other part of the problem - circular linking.
Comment 2 Nikoli 2014-07-22 07:08:59 UTC 
Also media-libs/harfbuzz dep in ebuild is wrong, now it is:
harfbuzz? ( >=media-libs/harfbuzz-0.9.12[truetype,${MULTILIB_USEDEP}] )

But it should be at least >= 0.9.19 as told in builds/unix/configure{,ac}:
$ grep 'harfbuzz.*>=' freetype-2.5.3/builds/unix/configure*
freetype-2.5.3/builds/unix/configure:  harfbuzz_pkg="harfbuzz >= 0.9.19"
freetype-2.5.3/builds/unix/configure.ac:  harfbuzz_pkg="harfbuzz >= 0.9.19"
freetype-2.5.3/builds/unix/configure.raw:  harfbuzz_pkg="harfbuzz >= 0.9.19"

and in docs/CHANGES:
"You need HarfBuzz version 0.9.19 or newer."


But minimal version of media-libs/harfbuzz with multilib in tree is 0.9.26-r1:
portage $ grep 'inherit.*multilib' media-libs/harfbuzz/harfbuzz-*
media-libs/harfbuzz/harfbuzz-0.9.26-r1.ebuild:inherit eutils libtool multilib-minimal python-any-r1
media-libs/harfbuzz/harfbuzz-0.9.28.ebuild:inherit eutils libtool multilib-minimal python-any-r1
media-libs/harfbuzz/harfbuzz-9999.ebuild:inherit eutils libtool multilib-minimal python-any-r1

Seems it was missed by mistake in http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-libs/freetype/freetype-2.5.3-r1.ebuild?r1=1.7&r2=1.8
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-07-22 19:15:20 UTC 
Well, that change was supposed to only add minimal EAPI 5 deps automatically :). You can't expect us to read every single configure.ac if maintainers failed to specify their dependencies properly.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-10-13 07:11:26 UTC 
+  13 Oct 2014; Michał Górny <mgorny@gentoo.org> freetype-2.5.3-r1.ebuild:
+  Bump harfbuzz dep to match configure check, pointed out in bug #517442.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-10-13 11:10:19 UTC 
Is there anything left to be done here, for multilib?
Comment 6 Ben de Groot (RETIRED) gentoo-dev 2014-12-13 10:56:51 UTC 
Looks like this is all fixed now. Unmasking.