Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 516570 - app-laptop/tp_smapi: uses RESTRICT=userpriv
Summary: app-laptop/tp_smapi: uses RESTRICT=userpriv
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michael Orlitzky
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 516568
  Show dependency tree
 
Reported: 2014-07-07 07:09 UTC by Michał Górny
Modified: 2016-08-06 03:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-07-07 07:09:20 UTC
Why does it use RESTRICT=userpriv? There's no comment in the ebuild and package seems to install fine without it.

RESTRICT=userpriv is not something to be used lightly. Please revise it and either remove it, or add a comment why it is needed. In the latter case, please keep the bug open until the underlying issue is fixed so that RESTRICT can be removed.
Comment 1 Michael Orlitzky gentoo-dev 2016-08-06 03:10:40 UTC
Well, I couldn't figure out why RESTRICT=userpriv was there, so I removed it in the new version 0.42. I added myself as maintainer, so if there was some corner case that I just broke, I'm sure I'll hear about it.

commit 79e2115d8a44bbec89f09f7b328313ee3dc86a16
Author: Michael Orlitzky <mjo@gentoo.org>
Date:   Fri Aug 5 23:01:07 2016 -0400

    app-laptop/tp_smapi: new version 0.42.

    This adds a new version 0.42, and updates the ebuild a bit.

    First, the ebuild was updated to EAPI=6. Then the RESTRICT=userpriv
    was removed, as it no longer seems to have any effect: I can install
    the package fine with FEATURES=userpriv. Next, an obsolete kernel
    version check was removed. Every version of every flavor of Linux
    sources we have in the tree is already newer than 2.6.19. Finally,
    einstalldocs (from EAPI=6) was used to install the current set of docs
    as well as a TODO that had been omitted.

    I have added myself as the maintainer of this package, since I still
    have hardware that it supports.

    Gentoo-Bug: 516570
    Gentoo-Bug: 583206

    Package-Manager: portage-2.2.28