Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 514010 - dev-vcs/git-2.0.0* USE="cgi perl" - git-instaweb not available
Summary: dev-vcs/git-2.0.0* USE="cgi perl" - git-instaweb not available
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-06-20 12:59 UTC by Quentin Minster
Modified: 2014-07-07 03:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for dev-vcs/git/files/git-2.0.0-optional-cvs.patch (file_514010.txt,706 bytes, patch)
2014-06-20 13:01 UTC, Quentin Minster
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Quentin Minster 2014-06-20 12:59:19 UTC
git instaweb is not available even though git IS built with USE="cgi perl". Note that git builds fine, the error only appears when trying to run `git instaweb`.

This is due to a bug in dev-vcs/git/files/git-2.0.0-optional-cvs.patch, which defines two Makefile targets for git-instaweb (broken NO_PERL logic patching).

Patches git-*-optional-cvs.patch for <dev-vcs/git-2.* work correctly. The bug was introduced at git-2.0.0-optional-cvs.patch:98 (correct line: git-1.9.0_rc3-optional-cvs.patch:85).

(Patch git-2.0.0_rc0-optional-cvs.patch used by the Git live ebuilds also does NOT have the bug.)

Reproducible: Always

Steps to Reproduce:
1. USE="cgi perl" emerge -av =dev-vcs/git-2.0.0-r1
2. git instaweb
Actual Results:  
$ USE="cgi perl" emerge -av =dev-vcs/git-2.0.0-r1
> Makefile:1849: warning: overriding recipe for target `git-instaweb'
> Makefile:1840: warning: ignoring old recipe for target `git-instaweb'

$ git instaweb
> fatal: git was built without support for git-instaweb (NO_PERL=).


Expected Results:  
Normal git-instaweb operation.
Comment 1 Quentin Minster 2014-06-20 13:01:28 UTC
Created attachment 379310 [details, diff]
patch for dev-vcs/git/files/git-2.0.0-optional-cvs.patch

Removing the extra "git-instaweb" target from the list of Perl targets not to build fixes the bug.
Comment 2 Ian Abbott 2014-07-04 16:33:09 UTC
Quentin's analysis is spot on, I reckon!
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2014-07-07 03:56:18 UTC
InCVS.