510768 – git-r3.eclass should check for "git +curl" if chosen transport is https

Bug 510768 - git-r3.eclass should check for "git +curl" if chosen transport is https

Summary: git-r3.eclass should check for "git +curl" if chosen transport is https

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Michał Górny

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2014-05-19 15:33 UTC by Anton Bolshakov
Modified:	2014-05-23 07:09 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Patch v1 (0001-Error-out-when-fetching-via-https-with-git-curl.patch,1.12 KB, patch) 2014-05-20 18:30 UTC, Michał Górny	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Anton Bolshakov 2014-05-19 15:33:31 UTC

I have hit a bug on default profile. Here is the output:

 * Package:    net-analyzer/metasploit-9999
 * Repository: gentoo
 * Maintainer: zerochaos@gentoo.org
 * USE:        amd64 elibc_glibc kernel_linux pcap ruby_targets_ruby19 userland_GNU
 * FEATURES:   preserve-libs sandbox userpriv usersandbox
>>> Unpacking source...
 * Running unpack phase for all ...
Initialized empty Git repository in /usr/portage/distfiles/git3-src/rapid7_metasploit-framework.git/
 * Fetching https://github.com/rapid7/metasploit-framework.git ...
git fetch https://github.com/rapid7/metasploit-framework.git +HEAD:refs/git-r3/HEAD
fatal: Unable to find remote helper for 'https'

after some googling I found that git must be compiled with curl:
http://stackoverflow.com/questions/8329485/git-clone-fatal-unable-to-find-remote-helper-for-https

It would be good if git-3 eclass could warn users.

Comment 1 Michał Górny archtester

2014-05-20 18:30:44 UTC

Created attachment 377306 [details, diff]
Patch v1

Please test this patch.

Comment 2 Anton Bolshakov 2014-05-23 02:56:24 UTC

Yes, the patch works:

 * Messages for package net-analyzer/metasploit-9999:

 * git-r3: fetching from https:// requested. In order to support https,
 * dev-vcs/git needs to be built with USE=curl. Example solution:
 * 
 *      echo dev-vcs/git curl >> /etc/portage/package.use
 *      emerge -1v dev-vcs/git
 * ERROR: net-analyzer/metasploit-9999::gentoo failed (unpack phase):
 *   dev-vcs/git built with USE=curl required.

Comment 3 Michał Górny archtester

2014-05-23 07:09:27 UTC

Thanks. Committed now.

+  23 May 2014; Michał Górny <mgorny@gentoo.org> git-r3.eclass:
+  Give an explanatory error when trying to fetch https:// with
+  dev-vcs/git[-curl]. Bug #510768.