There is a nice emacs plugin in the contrib/ directory of pass. password-store.el: http://git.zx2c4.com/password-store/tree/contrib/emacs/password-store.el Cask: http://git.zx2c4.com/password-store/tree/contrib/emacs/Cask I'm not sure the best way to go about incorporating this. It has dependencies, like "dash". But I don't know much about emacs. Would somebody on the emacs team integrate this into my package? Reproducible: Always
Created attachment 376618 [details, diff] My best attempt at adding support to the ebuilds
Created attachment 376620 [details] My best attempt at a site file
--- ./ChangeLog +++ ./ChangeLog @@ -4,0 +5,4 @@ + 09 May 2014; Jason A. Donenfeld <zx2c4@gentoo.org> +files/50pass-gentoo.el, + pass-1.6.1-r1.ebuild, pass-9999.ebuild: + Add initial emacs support. + Probably I did something wrong and should not have committed this. That was a mistake I'm guessing. Ah well, hm.
(In reply to Jason A. Donenfeld from comment #1) > Created attachment 376618 [details, diff] [details, diff] > My best attempt at adding support to the ebuilds Looks good. (You could omit the "|| die" after elisp-install and elisp-site-file-install because these functions die by themselves. But that's very minor.) (In reply to Jason A. Donenfeld from comment #2) > Created attachment 376620 [details] > My best attempt at a site file Looks good, too. However: I see that the ebuild that you've committed to the tree doesn't call elisp-compile any more. And if I add it to src_compile() then it will fail: >>> Compiling source in /var/tmp/portage/app-admin/pass-1.6.1-r1/work/password-store-1.6.1 ... * Compiling GNU Emacs Elisp files ... In toplevel form: contrib/emacs/password-store.el:34:1:Error: Cannot open load file: f * elisp-compile: batch-byte-compile failed [ !! ] * ERROR: app-admin/pass-1.6.1-r1::gentoo failed (compile phase): * (no error message) Looks like it misses some dependencies called "f" and "s". Whatever that is. So in summary, by omitting the elisp-compile step you've worked around the compile failure, but users will get the same errors now at runtime, when they first load password-store.el. (In reply to Jason A. Donenfeld from comment #3) > Probably I did something wrong and should not have committed this. Yes, unfortunately. Your first versions of the ebuild and site file were close to perfect, but the problem is in password-store.el itself.
Hmm yea, I was afraid of that. On mine, it complained about the "dash" dependency. (Where does this come from? Googling reveals it's some kind of list library?) I've emailed Svend, the author, to chime in.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1d923862d3785cf08d5b2e6f5b67043f59e77ff1 commit 1d923862d3785cf08d5b2e6f5b67043f59e77ff1 Author: Hans de Graaff <graaff@gentoo.org> AuthorDate: 2018-07-17 19:04:05 +0000 Commit: Hans de Graaff <graaff@gentoo.org> CommitDate: 2018-07-17 19:04:05 +0000 app-admin/pass: fix emacs dependencies Add dependencies for emacs and compile the emacs code. This drops arm x86 x86-macos keywords, see bug 661432 Closes: https://bugs.gentoo.org/509914 Package-Manager: Portage-2.3.40, Repoman-2.3.9 app-admin/pass/pass-1.7.2-r1.ebuild | 78 +++++++++++++++++++++++++++++++++++++ 1 file changed, 78 insertions(+)
