Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 509606 - net-im/tkabber-9999 ebuild — cleanups and improvements for tkabber-svn ebuild
Summary: net-im/tkabber-9999 ebuild — cleanups and improvements for tkabber-svn ebuild
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: No maintainer - Look at if you want to take care of it
Keywords: EBUILD
Depends on: 280898
  Show dependency tree
Reported: 2014-05-05 07:39 UTC by Alexander Turenko
Modified: 2016-09-03 08:44 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---

tkabber-9999.ebuild (tkabber-9999.ebuild,8.97 KB, text/plain)
2014-05-05 07:39 UTC, Alexander Turenko
metadata.xml (metadata.xml,1.02 KB, text/plain)
2014-05-05 07:40 UTC, Alexander Turenko

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Turenko 2014-05-05 07:39:31 UTC
Created attachment 376408 [details]

This is actualized ebuild from #233915 with new name (tkabber-9999 instead tkabber-svn-0) and some improvements.

Approximate changes list:
* EAPI="5" and proper changes
* rename "crypt" USE to "gpg" due to fix misunderstanding with tls and otr
* update metadata.xml with USE description
* choose some of IUSE to be default-enabled
* vimage requires tkimg
* compile lib for vimage
* remove "debug" USE (was used for debug of ebuild itself)

All required packages for this currently in main tree, except tclgpg, see #280898. So it would be a good thing, if this ebuild (as well as tclgpg) will be placed in main tree.

It also required icon file from #233915 (expected in files/ dir).
Comment 1 Alexander Turenko 2014-05-05 07:40:23 UTC
Created attachment 376410 [details]
Comment 2 Manuel Rüger (RETIRED) gentoo-dev 2015-06-01 11:12:28 UTC
Please provide a patch instead of a full rewrite.
Comment 3 Alexander Turenko 2015-06-01 18:21:10 UTC
Tkabber migrates to the fossil vcs, so svn-based ebuild isn’t actual for now. I will update the ebuild when I will have free time for that.

There is no difference how many lines changed, a patch (not entire file) must be attached? The patch must be based on current portage tree ebuild (for old release, without vcs support) or on widely used ebuild from #233915 (live)?
Comment 4 Antek Grzymała (antoszka) 2015-06-03 11:55:24 UTC
There's a live ebuild for tkabber in the 'booboo' overlay that supports the new  fossil VCS code hosting and includes some Tcl deps like the native tclgpg implementation needed for PGP support, so it doesn't make sense to duplicate efforts. Either use the one from the overlay or review/import it into the main portage tree.

Works fine for me I've migrated succesfully from the old one.
Comment 5 Alexander Turenko 2016-08-26 00:20:37 UTC
Described enhancements are in 'booboo' overlay for now. There are two notable differences between this ebuild and booboo's one (except fossil support).

Booboo's ebuild doesn't create /etc/env.d/99tkabber file to setup path to external plugins. It could be achieved by 'set env(TKABBER_SITE_PLUGINS) /usr/share/tkabber/site-plugins' in user's ~/.tkabber/config.tcl. I'll look into the problem and probably will add patching sources for setup proper default path.

The second difference is removing foolsday plugins which anger overlay's owner :) It works only April, 1 and quite useless (just foolish), so never mind.

L29Ah (booboo's owner) says he doesn't want to support this ebuild in the main portage tree, but comfortable if someone grab it into the tree :) Personally I would be glad if the ebuild will be in the main tree.
Comment 6 Alexander Turenko 2016-09-03 08:44:03 UTC

The first difference eliminated by 'fix-site-plugins-path' USE flag. It patches Tkabber sources to load external plugins from the default location (where ebuild installs external plugins) when TKABBER_SITE_PLUGINS isn't set.

The second one still there, but it can be safely removed. The 'shuffle' internal plugin disabled now (return keyword at the begin), the 'flip' one is external and isn't mandatory to install (controlled by TKABBER_PLUGINS make.conf variable).