Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 509332 - =app-cdr/k3b-2.0.3-r2: stabilization
Summary: =app-cdr/k3b-2.0.3-r2: stabilization
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard: was: app-cdr/k3b with media-video/lib...
Keywords: STABLEREQ
: 524814 539870 (view as bug list)
Depends on:
Blocks: libav-10
  Show dependency tree
 
Reported: 2014-05-01 22:10 UTC by Nikoli
Modified: 2015-06-12 09:15 UTC (History)
10 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nikoli 2014-05-01 22:10:46 UTC
Both ebuild from tree fails to build with libav-10:

k3b-2.0.2/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:171:9: error: '::av_close_input_file' has not been declared
k3b-2.0.2/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:216:10: error: 'CODEC_ID_WMAV1' was not declared in this scope
k3b-2.0.2/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:218:10: error: 'CODEC_ID_WMAV2' was not declared in this scope
k3b-2.0.2/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:223:10: error: 'CODEC_ID_MP3' was not declared in this scope
k3b-2.0.2/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:226:10: error: 'CODEC_ID_AAC' was not declared in this scope
k3b-2.0.2/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:331:19: error: '::avcodec_decode_audio3' has not been declared
k3b-2.0.2/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:422:29: error: 'CODEC_ID_WMAV1' was not declared in this scope
k3b-2.0.2/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:423:29: error: 'CODEC_ID_WMAV2' was not declared in this scope
k3b-2.0.2/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:424:29: error: 'CODEC_ID_AAC' was not declared in this scope


k3b-2.0.2_p20140225/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:341:19: error: '::avcodec_decode_audio' has not been declared
k3b-2.0.2_p20140225/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:426:29: error: 'CODEC_ID_WMAV1' was not declared in this scope
k3b-2.0.2_p20140225/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:427:29: error: 'CODEC_ID_WMAV2' was not declared in this scope
k3b-2.0.2_p20140225/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:428:29: error: 'CODEC_ID_AAC' was not declared in this scope
Comment 1 Michael Palimaka (kensington) gentoo-dev 2014-10-09 09:57:22 UTC
*** Bug 524814 has been marked as a duplicate of this bug. ***
Comment 2 Paolo Pedroni 2014-10-09 10:35:18 UTC
app-cdr/k3b-2.0.2_p20140225 is unaffected (from the ffmpeg bug, at least). Oh, how I wish that the development team would cut a new release....
Comment 3 Michael Palimaka (kensington) gentoo-dev 2014-10-09 10:40:46 UTC
Unfortunately k3b upstream is pretty dead. We do try to add a a new snapshot from time to time (usually when bugs like this get fixed).
Comment 4 Manuel Rüger (RETIRED) gentoo-dev 2014-11-04 10:26:26 UTC
k3b-2.0.3 is in tree. Please test and report back if it fails.
Comment 5 Paolo Pedroni 2014-11-04 14:07:53 UTC
(In reply to Manuel Rüger from comment #4)
> k3b-2.0.3 is in tree. Please test and report back if it fails.

k3b-2.0.3 works fine, thanks.
Comment 6 Nikoli 2014-11-06 06:34:10 UTC
app-cdr/k3b-2.0.3-r1 still fails with libav-10.5:
k3b-2.0.3/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:341:19: error: '::avcodec_decode_audio' has not been declared
k3b-2.0.3/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:426:29: error: 'CODEC_ID_WMAV1' was not declared in this scope
k3b-2.0.3/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:427:29: error: 'CODEC_ID_WMAV2' was not declared in this scope
k3b-2.0.3/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:428:29: error: 'CODEC_ID_AAC' was not declared in this scope
Comment 7 Paolo Pedroni 2014-11-06 09:40:34 UTC
(In reply to Paolo Pedroni from comment #5)
> (In reply to Manuel Rüger from comment #4)
> > k3b-2.0.3 is in tree. Please test and report back if it fails.
> 
> k3b-2.0.3 works fine, thanks.

Replying to myself, k3b-2.0.3-r1 works fine with ffmpeg-2.4.3
Comment 8 Johannes Huber (RETIRED) gentoo-dev 2015-02-13 09:54:48 UTC
*** Bug 539870 has been marked as a duplicate of this bug. ***
Comment 9 Alexis Ballier gentoo-dev 2015-02-15 10:55:24 UTC
2.0.3-r1 is ok with ffmpeg, adjusting summary
Comment 10 SpanKY gentoo-dev 2015-02-17 03:50:52 UTC
i've fixed the CODEC_ID_xxx errors.  the code already had workarounds, but forgot to use them in part of the file.

http://sources.gentoo.org/app-cdr/k3b/k3b-2.0.3-r1.ebuild?r1=1.3&r2=1.4
http://sources.gentoo.org/app-cdr/k3b/files/k3b-2.0.3-libav-10.patch?rev=1.1

the avcodec_decode_audio error remains.  this is because it needs porting to avcodec_decode_audio4 already (see the myriad of bugs upstream about it).
Comment 11 SpanKY gentoo-dev 2015-02-17 03:55:43 UTC
for anyone who wants to fix things, see this page:
https://wiki.libav.org/Migration/10

the "audio decoding API" section provides an overview of migrating from x3 to x4
Comment 12 Oldrich Jedlicka 2015-02-17 20:48:29 UTC
I made a patch to make k3b compile with newer libav.

  https://git.reviewboard.kde.org/r/122569/

I have not tested the functionality (do not know how exactly), but I migrated the code according to the API example.
Comment 13 Egor Y. Egorov 2015-02-18 04:10:57 UTC
(In reply to Oldrich Jedlicka from comment #12)
> I made a patch to make k3b compile with newer libav.
> 
>   https://git.reviewboard.kde.org/r/122569/
> 
> I have not tested the functionality (do not know how exactly), but I
> migrated the code according to the API example.

Good job!
k3b with USE=ffmpeg built fine now in my case.
Can you please made same modifications for next bugs:
https://bugs.gentoo.org/show_bug.cgi?id=511778
https://bugs.gentoo.org/show_bug.cgi?id=539894
Thanks.
Comment 14 Ettore Di Giacinto (RETIRED) gentoo-dev 2015-05-29 22:30:23 UTC
Added the Oldrich patch https://github.com/Sabayon/for-gentoo/commit/f905fd5c6a8d1a266396100eb6f3cedf03d421de on sabayon overlay, working also for libav 11.3
Comment 15 Johannes Huber (RETIRED) gentoo-dev 2015-05-30 13:44:56 UTC
Thanks all. This is fixed in cvs now.

+
+  30 May 2015; Johannes Huber <johu@gentoo.org> +files/k3b-2.0.3-libav-11.patch,
+  +k3b-2.0.3-r2.ebuild:
+  Revision bump adds patch to fix build with libav-11, bug #509332. Thanks to
+  Oldrich Jedlicka <oldium.pro@seznam.cz>.
+


Arches please stabilize  =app-cdr/k3b-2.0.3-r2 as soon as possible as libav11 is already stable. 

Target: amd64 x86
Comment 16 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2015-06-05 14:52:08 UTC
amd64 stable
Comment 17 Agostino Sarubbo gentoo-dev 2015-06-09 07:23:21 UTC
x86 stable. Closing.