Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 508698 - dev-python/socketpool-0.5.3 - REQUIRED_USE incorrectly sets gevent? ( python_targets_python2_6 python_targets_python2_7 )
Summary: dev-python/socketpool-0.5.3 - REQUIRED_USE incorrectly sets gevent? ( python_...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ian Delaney (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-25 16:11 UTC by James Cloos
Modified: 2014-06-29 09:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Cloos 2014-04-25 16:11:56 UTC 
0.5.3 added a REQUIRED_USE, but the syntax is wrong.

It has:

REQUIRED_USE="gevent? ( $(python_gen_useflags 'python2*') )"

which results in ( python_targets_python2_6 python_targets_python2_7 )

even when only 2.7 is in USE_PYTHON and 2.6 is not merged.

Per the example in the eclass, it needs the enclose the $() in !!().
Comment 1 Mike Gilbert gentoo-dev 2014-04-25 20:07:34 UTC 
+  25 Apr 2014; Mike Gilbert <floppym@gentoo.org> socketpool-0.5.3.ebuild:
+  Drop optional runtime dependency on dev-python/gevent, bug 508698.
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2014-04-29 10:11:34 UTC 
this is NOT what I would have done.
Comment 3 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2014-04-29 15:23:19 UTC 
please do not remove optional dependancies when fixing bugs like this, better to fix how the dep is called (convert to python-r1 or something).
Comment 4 Mike Gilbert gentoo-dev 2014-04-29 15:56:29 UTC 
(In reply to Matthew Thode ( prometheanfire ) from comment #3)

Talk to the QA team and get the devmanual changed if you like.
Comment 5 Mike Gilbert gentoo-dev 2014-04-29 16:18:31 UTC 
Here's a patch if you want to restore the use flag and optional dependency.

I would leave the REQUIRED_USE check out; it should be unnecessary with the newer python_gen_cond_dep syntax.

http://bpaste.net/raw/246589/
Comment 6 Ian Delaney (RETIRED) gentoo-dev 2014-06-29 09:47:05 UTC 
  30 Apr 2014; Ian Delaney <idella4@gentoo.org> metadata.xml,
  socketpool-0.5.3.ebuild:
  see Bug 508698