Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 508438 - app-admin/eselect-wxwidgets: discuss prefix changes
Summary: app-admin/eselect-wxwidgets: discuss prefix changes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo wxWidgets project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2014-04-22 17:18 UTC by Christoph Junghans (RETIRED)
Modified: 2014-04-23 19:57 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Junghans (RETIRED) gentoo-dev 2014-04-22 17:18:36 UTC
In short, to add prefix support we need to change the following things:

1.)
$ sed -i 's/base gtk2/& mac/' wxwidgets.eselect
I have commit rights for eselect.git and can do that change and make a new release

2.)
$ sed -i 's@/\(var\|usr\)/lib@${EPREFIX}&@' wx{rc,-config}
We could do this using sed in the ebuild or eprefixify with a version having @GENTOO_PORTAGE_EPREFIX@ in there. Any preference?

One a side note, wx{rc,-config} contains a hard-coded /usr/lib, which should be /usr/$(get_libdir) instead.

I think the cleanest would be to something like in the recent ccache builds:
$ sed -e "/^LIBDIR=/s:lib:$(get_libdir):" -e "/^EPREFIX=/s:'':'${EPREFIX}':"

And define LIBDIR and EPREFIX somewhere in the the top of wx{rc,-config}.
Comment 1 Ryan Hill (RETIRED) gentoo-dev 2014-04-23 01:05:53 UTC
> In short, to add prefix support we need to change the following things:
> 
> 1.)
> $ sed -i 's/base gtk2/& mac/' wxwidgets.eselect
> I have commit rights for eselect.git and can do that change and make a new
> release

Okay.  I need to add gtk3 one of these days but I won't hold you up, so go ahead.
 
> 2.)
> $ sed -i 's@/\(var\|usr\)/lib@${EPREFIX}&@' wx{rc,-config}
> We could do this using sed in the ebuild or eprefixify with a version having
> @GENTOO_PORTAGE_EPREFIX@ in there. Any preference?

sed please.

> One a side note, wx{rc,-config} contains a hard-coded /usr/lib, which should
> be /usr/$(get_libdir) instead.
> 
> I think the cleanest would be to something like in the recent ccache builds:
> $ sed -e "/^LIBDIR=/s:lib:$(get_libdir):" -e "/^EPREFIX=/s:'':'${EPREFIX}':"
> 
> And define LIBDIR and EPREFIX somewhere in the the top of wx{rc,-config}.

This sounds good to me.
Comment 2 Christoph Junghans (RETIRED) gentoo-dev 2014-04-23 19:55:22 UTC
+*eselect-wxwidgets-20140423 (23 Apr 2014)
+
+  23 Apr 2014; Christoph Junghans <ottxor@gentoo.org>
+  +eselect-wxwidgets-20140423.ebuild, +files/wx-config-1.4, +files/wxrc-1.4:
+  add prefix support (bug #508438)
+