Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 507850 - dev-util/scons - files/scons-1.2.0-popen.patch ?
Summary: dev-util/scons - files/scons-1.2.0-popen.patch ?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-16 20:26 UTC by Álvaro
Modified: 2014-04-22 17:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Álvaro 2014-04-16 20:26:47 UTC
Mypaint git fails to build because some modified code on scons-2.x
Specifically this patch from 1.2: http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/dev-util/scons/files/scons-1.2.0-popen.patch?annotate=1.1 is messing with the proper building of the software.
Reverting the changes fixes that.

In short, I commented out:

try:
    import subprocess
except ImportError:
#    # Pre-2.4 Python has no subprocess module.
    import_as('_scons_subprocess', 'subprocess')



~/builds/mypaint $ scons
scons: Reading SConscript files ...
Gentoo: /etc/gentoo-release exists. Must be on a Gentoo based system.
building for 'python2.7' (use scons python_binary=xxx to change)
using 'python-config-2.7' (use scons python_config=xxx to change)
rm -f libmypaint-tests.so libmypaint.so libmypaintlib.so
Enabling i18n for brushlib in full application build
ImportError: cannot import name check_output:
  File "/home/alvaro/builds/mypaint/SConstruct", line 201:
    application = SConscript('./SConscript')
  File "/usr/lib64/python2.7/site-packages/SCons/Script/SConscript.py", line 609:
    return method(*args, **kw)
  File "/usr/lib64/python2.7/site-packages/SCons/Script/SConscript.py", line 546:
    return _SConscript(self.fs, *files, **subst_kw)
  File "/usr/lib64/python2.7/site-packages/SCons/Script/SConscript.py", line 260:
    exec _file_ in call_stack[-1].globals
  File "/home/alvaro/builds/mypaint/SConscript", line 4:
    from subprocess import check_output
Comment 1 Álvaro 2014-04-16 20:28:01 UTC
emerge --info
Portage 2.2.8-r1 (default/linux/amd64/13.0/desktop, gcc-4.7.3, glibc-2.17, 3.10.25-gentoo x86_64)
=================================================================
System uname: Linux-3.10.25-gentoo-x86_64-Intel-R-_Core-TM-_i5_CPU_650_@_3.20GHz-with-gentoo-2.2
KiB Mem:     3913640 total,    213140 free
KiB Swap:    7815616 total,   7804684 free
Timestamp of tree: Wed, 16 Apr 2014 17:30:01 +0000
ld GNU ld (GNU Binutils) 2.23.2
app-shells/bash:          4.2_p45
dev-java/java-config:     2.2.0
dev-lang/python:          2.7.5-r3, 3.2.5-r3, 3.3.3
dev-util/cmake:           2.8.12.2
dev-util/pkgconfig:       0.28
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.12.4
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.10.3, 1.11.6, 1.12.6, 1.13.4
sys-devel/binutils:       2.23.2
sys-devel/gcc:            4.7.3-r1
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.9 (virtual/os-headers)
sys-libs/glibc:           2.17
Repositories: gentoo steam-overlay sublime-text
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -march=native"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="ftp://ftp.free.fr/mirrors/ftp.gentoo.org/"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/steam /var/lib/layman/sublime-text"
USE="X a52 aac acl acpi alsa amd64 berkdb bindist branding bzip2 cairo cdda cdr cli consolekit cracklib crypt cups cxx dbus device-mapper dri dts dvd dvdr emboss encode evdev exif fam ffmpeg firefox flac fontconfig fortran gdbm gif gpm gtk hal iconv ipod ipv6 jpeg lcms ldap libnotify mad matroska mmx mmxext mng modules mp3 mp4 mpeg mtp multilib ncurses nls nptl ogg opengl openmp pam pango pcre pdf png policykit ppds pulseaudio python qt3support readline sdl session spell sse sse2 ssl ssse3 startup-notification svg tcpd tiff truetype udev udisks unicode upower usb v4l v4l2 vlc vorbis wacom win32codecs wxwidgets x264 xcb xml xv xvid zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="krita" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev joystick wacom" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en_GB es" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="vesa nvidia v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, SYNC, USE_PYTHON
Comment 2 Mike Gilbert gentoo-dev 2014-04-16 23:39:16 UTC
bicatali: You introduced this patch, but did not cite any specific failure or bug report.

What package was failing with the stdlib subprocess module?
Comment 3 Álvaro 2014-04-16 23:49:08 UTC
Hi Mike Gilbert, are you replyng me? I did not propose any patch, just posted one from gentoo from 5 years ago, and then I posted a workaround to make it work.
Comment 4 Mike Gilbert gentoo-dev 2014-04-17 00:34:22 UTC
(In reply to Álvaro from comment #3)
> Hi Mike Gilbert, are you replyng me?

No, I am asking a question of another Gentoo developer (username 'bicatali').
Comment 5 Mike Gilbert gentoo-dev 2014-04-17 00:36:04 UTC
Of course, it might help if I actually copied him... ^_^

bicatali: Please see my question above.
Comment 6 Álvaro 2014-04-22 11:01:07 UTC
(In reply to Mike Gilbert from comment #5)
> Of course, it might help if I actually copied him... ^_^
> 
> bicatali: Please see my question above.

Any advance on this issue?
My proposed fix worked for me and I haven't break anything. I'm pretty sure this affected more people because I googlinvestigated a bit when I had this issue and found several people with the same problem.
Next mypaint release will have to deal with this problem only on gentoo.
Comment 7 Sébastien Fabbro (RETIRED) gentoo-dev 2014-04-22 17:19:03 UTC
(In reply to Mike Gilbert from comment #2)
> bicatali: You introduced this patch, but did not cite any specific failure
> or bug report.
> 
> What package was failing with the stdlib subprocess module?


sorry i really can't remember the rationales behind this patch that i should have commented. i'm guessing it was not really robust with threads according to the content. other distros don't seem to apply it, i suggest punting the patch.
Comment 8 Mike Gilbert gentoo-dev 2014-04-22 17:41:43 UTC
+*scons-2.3.1-r1 (22 Apr 2014)
+
+  22 Apr 2014; Mike Gilbert <floppym@gentoo.org> +scons-2.3.1-r1.ebuild:
+  Drop scons-1.2.0-popen.patch, bug 507850 by Álvaro.