Bug 507730 – app-admin/rsyslog-7.4.10 with dev-libs/json-c-0.12 - mmjsonparse.c:149:14: error: 'json_tokener_errors' undeclared (first use in this function)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Maxim Koltsov (RETIRED) 2014-04-15 15:29:37 UTC]

rsyslog fails to build with the error:

mmjsonparse.c: In function 'processJSON':
mmjsonparse.c:149:14: error: 'json_tokener_errors' undeclared (first use in this function)
     errMsg = json_tokener_errors[err];
              ^
Apparently, json_tokener_errors is removed from json-c, but function "json_tokener_error_desc" can be used instead (see attached patch).

Reproducible: Always

[Comment 1 Maxim Koltsov (RETIRED) 2014-04-15 15:34:15 UTC]

Created attachment 375014 [details]
build.log

[Comment 2 Maxim Koltsov (RETIRED) 2014-04-15 15:34:28 UTC]

Created attachment 375016 [details, diff]
proposed patch

[Comment 3 Thomas Deutschmann (RETIRED) 2014-04-15 15:39:44 UTC]

I'd a bad feeling when I saw the dev-libs/json-c-0.12 update last week :(

I filled an bug report upstream: https://github.com/rsyslog/rsyslog/issues/61

Thanks.

[Comment 4 Thomas Deutschmann (RETIRED) 2014-04-16 09:24:04 UTC]

Created attachment 375076 [details, diff]
Patch for the portage tree to update the rsyslog ebuilds

@ Maxim: Upstream accepted your proposed patch. Thank you!

I am attaching a patch for the portage tree which will add the patch to all existing rsyslog ebuilds. Should be applied in "/usr/portage" with "patch -p1 < ...".

Could anybody with commit access please apply this patch to the tree?

Please don't forget to update the Manifest for *all* the ebuilds!

Thanks.

[Comment 5 Maxim Koltsov (RETIRED) 2014-04-16 16:15:17 UTC]

As the patch is trivial and was accepted upstream, I commited it to the tree.