Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 506934 - dev-libs/zthread-2.3.2-r3 with sys-devel/clang - ../include/zthread/Guard.h:117:9: error: void function 'createScope' should not return a value [-Wreturn-type]
Summary: dev-libs/zthread-2.3.2-r3 with sys-devel/clang - ../include/zthread/Guard.h:1...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Austin English (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: systemwide-clang
  Show dependency tree
 
Reported: 2014-04-06 13:36 UTC by Priit Laes (IRC: plaes)
Modified: 2016-06-02 21:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
zthread-2.3.2-r3-build.log (build.log,13.03 KB, text/plain)
2014-04-06 13:36 UTC, Priit Laes (IRC: plaes)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Priit Laes (IRC: plaes) 2014-04-06 13:36:33 UTC
Created attachment 374374 [details]
zthread-2.3.2-r3-build.log

Build of zthread-2.3.2-r3 with clang-3.4 fails with following error:
[snip]
libtool: compile:  clang++ -DHAVE_CONFIG_H -I. -I../include -mtune=core2 -O2 -pipe -ggdb -Wall -DNDEBUG -mtune=core2 -O2 -pipe -ggdb -Wall -DNDEBUG -c AtomicCount.cxx  -fPIC -DPIC -o .libs/AtomicCount.o
In file included from AtomicCount.cxx:55:
In file included from ./vanilla/SimpleAtomicCount.cxx:26:
../include/zthread/Guard.h:117:9: error: void function 'createScope' should not return a value [-Wreturn-type]
        return false;
        ^      ~~~~~
../include/zthread/Guard.h:121:5: error: void function 'createScope' should not return a value [-Wreturn-type]
    return true;
    ^      ~~~~
2 errors generated.
Makefile:565: recipe for target 'AtomicCount.lo' failed
make[3]: *** [AtomicCount.lo] Error 1
[/snip]
Comment 1 Fabio Scaccabarozzi 2014-08-07 14:52:43 UTC
According to a grep on the tree, the only package depending on zthread is hugin, which... bundles its own version.
Upstream seems dead, last release was on 2005-03-13, I don't think it will be possible to upstream the patch.

The references I've found, which contain the patch that Hugin uses:
https://bugs.launchpad.net/hugin/+bug/1213585
https://sourceforge.net/p/hugin/mailman/message/31382899/
Comment 2 Austin English (RETIRED) gentoo-dev 2016-06-02 08:23:45 UTC
I sent a PR and notified maintainers on IRC:
https://github.com/gentoo/gentoo/pull/1585
Comment 3 Austin English (RETIRED) gentoo-dev 2016-06-02 21:45:05 UTC
(In reply to Austin English from comment #2)
> I sent a PR and notified maintainers on IRC:
> https://github.com/gentoo/gentoo/pull/1585

Fixed by dev-libs/zthread-2.3.2-r4

https://github.com/gentoo/gentoo/commit/5f3562b328dcadeb4f73863bac2128a67df87eda