Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 504756 - app-arch/snappy - migrate to multilib
Summary: app-arch/snappy - migrate to multilib
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tim Harder
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks: gx86-multilib 468254
  Show dependency tree
 
Reported: 2014-03-16 02:41 UTC by David Heidelberg (okias)
Modified: 2014-04-03 18:22 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
snappy-1.1.2-r1-RFC.ebuild (snappy-1.1.2-r1.ebuild,977 bytes, text/plain)
2014-03-16 02:41 UTC, David Heidelberg (okias)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Heidelberg (okias) 2014-03-16 02:41:41 UTC
Created attachment 372778 [details]
snappy-1.1.2-r1-RFC.ebuild

RFC template in attachment, tested works.

Needed for apitrace-git
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2014-03-16 02:46:22 UTC
Comment on attachment 372778 [details]
snappy-1.1.2-r1-RFC.ebuild

--- snappy-1.1.2.ebuild 2014-03-11 21:33:15.000000000 +0100
+++ -   2014-03-16 03:45:56.135318392 +0100
@@ -1,10 +1,10 @@
 # Copyright 1999-2014 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/app-arch/snappy/snappy-1.1.2.ebuild,v 1.1 2014/03/11 20:33:15 radhermit Exp $
+# $Header: $
 
 EAPI="5"
 
-inherit eutils autotools
+inherit eutils autotools multilib-minimal
 
 DESCRIPTION="A high-speed compression/decompression library by Google"
 HOMEPAGE="https://code.google.com/p/snappy/"
@@ -26,9 +26,10 @@
        sed -i 's/COPYING INSTALL//' Makefile.am || die
 
        eautoreconf
+       multilib_copy_sources
 }
 
-src_configure() {
+multilib_src_configure() {
        econf \
                --docdir="${EPREFIX}"/usr/share/doc/${PF} \
                --without-gflags \
@@ -36,7 +37,6 @@
                $(use_enable static-libs static)
 }
 
-src_install() {
-       default
+multilib_src_install_all() {
        prune_libtool_files
 }
Comment 2 Tim Harder gentoo-dev 2014-03-20 21:14:43 UTC
I'd rather use the autotools-multilib eclass and it seems this will need gtest multilib changes since gtest-config should be installed per ABI (using MULTILIB_CHOST_TOOLS similar to *-config scripts for other multilib ported pkgs) otherwise it'll will give the wrong library path for linking when trying to build the testsuite.
Comment 3 SpanKY gentoo-dev 2014-04-03 18:22:20 UTC
should be all set now in the tree; thanks for the report!

Commit message: Convert to autotools-multilib
http://sources.gentoo.org/app-arch/snappy/snappy-1.1.2-r1.ebuild?rev=1.1