Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 504408 - media-libs/netpbm - files/make-tarball.sh should not source functions.sh from /etc/init.d
Summary: media-libs/netpbm - files/make-tarball.sh should not source functions.sh from...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: init.d_functions.sh
  Show dependency tree
 
Reported: 2014-03-13 02:38 UTC by hal
Modified: 2021-04-18 16:29 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description hal 2014-03-13 02:38:50 UTC
See bug 504116.
Comment 1 Olof Kindgren 2019-05-15 19:33:48 UTC
This now seems to be the only bug blocking https://bugs.gentoo.org/504116 but is the make-tarball.sh script even used anywhere? I can't find any reference to it in any of the ebuilds
Comment 2 Jacob Floyd 2020-04-02 19:29:11 UTC
make-tarball.sh seems to pre-date putting the gentoo repo in git.

Here's the first commit in git. There are no references to make-tarball.sh
https://gitweb.gentoo.org/repo/gentoo.git/commit/media-libs/netpbm?id=56bd759df1d0c750a065b8c845e93d5dfa6b549d

Here's the original CSV commit. There were no references then either:
https://gitweb.gentoo.org/repo/gentoo/historical.git/commit/media-libs/netpbm?id=3b45f0b1d55459dbf705b0a271ab59af45291e36

This was added by vapier, so adding him to CC.

I suspect this script is used (somehow) when revbumping this package to build the archive that goes on gentoo mirrors:
> SRC_URI="mirror://gentoo/${P}.tar.xz"

@vapier is the make-tarball.sh script still needed? If so, can you update it to use functions.sh in the correct location?
Comment 3 Larry the Git Cow gentoo-dev 2021-04-18 16:29:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ffff493f902d98593dae94a30e1bb1b62f5cbbd7

commit ffff493f902d98593dae94a30e1bb1b62f5cbbd7
Author:     Mike Frysinger <vapier@gentoo.org>
AuthorDate: 2021-04-18 16:26:42 +0000
Commit:     Mike Frysinger <vapier@gentoo.org>
CommitDate: 2021-04-18 16:29:11 +0000

    media-libs/netpbm: refresh make-tarball.sh helper
    
    Make it shellcheck clean too with a little bit of effort.
    
    Closes: https://bugs.gentoo.org/504408
    Signed-off-by: Mike Frysinger <vapier@gentoo.org>

 media-libs/netpbm/files/make-tarball.sh | 37 +++++++++++++++++++++++----------
 1 file changed, 26 insertions(+), 11 deletions(-)