Bug 504394 – media-gfx/splash-themes-livecd should not source functions.sh from /etc/init.d

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description hal 2014-03-13 02:38:40 UTC]

See bug 504116.

[Comment 1 Jeroen Roovers (RETIRED) 2014-03-13 15:26:04 UTC]

*** Bug 504396 has been marked as a duplicate of this bug. ***

[Comment 2 Jeroen Roovers (RETIRED) 2014-03-13 15:26:12 UTC]

*** Bug 504398 has been marked as a duplicate of this bug. ***

[Comment 3 Jeroen Roovers (RETIRED) 2014-03-13 15:26:19 UTC]

*** Bug 504400 has been marked as a duplicate of this bug. ***

[Comment 4 Jeroen Roovers (RETIRED) 2014-03-13 15:26:26 UTC]

*** Bug 504402 has been marked as a duplicate of this bug. ***

[Comment 5 Jeroen Roovers (RETIRED) 2014-03-13 15:26:33 UTC]

*** Bug 504404 has been marked as a duplicate of this bug. ***

[Comment 6 Jeroen Roovers (RETIRED) 2014-03-13 15:33:18 UTC]

*** Bug 504406 has been marked as a duplicate of this bug. ***

[Comment 7 hal 2014-03-14 11:33:12 UTC]

I'm about to create some patches for each of the affected packages:

splash-themes-livecd-2005.0.ebuild
24:	sed -i -e 's-/sbin/functions.sh-/etc/init.d/functions.sh-' scripts/rc_init-pre scripts/list_svc.sh

splash-themes-livecd-2005.1.ebuild
25:	sed -i -e 's-/sbin/functions.sh-/etc/init.d/functions.sh-' scripts/rc_init-pre

splash-themes-livecd-2006.0.ebuild
24:	sed -i -e 's-/sbin/functions.sh-/etc/init.d/functions.sh-' scripts/rc_init-pre

splash-themes-livecd-2006.1.ebuild
24:	sed -i -e 's-/sbin/functions.sh-/etc/init.d/functions.sh-' scripts/rc_init-pre

splash-themes-livecd-2007.0-r1.ebuild
34:	sed -i -e 's-/sbin/functions.sh-/etc/init.d/functions.sh-' \

splash-themes-livecd-2007.0.ebuild
34:	sed -i -e 's-/sbin/functions.sh-/etc/init.d/functions.sh-' scripts/rc_init-pre

splash-themes-livedvd-12.0-r1.ebuild
24:	sed -i -e 's:/sbin/functions.sh:/etc/init.d/functions.sh:' scripts/rc_init-pre

Do want to see patches for the ebuilds to "sed patch" the actual source or would you like to see patches for the source applied by epatch?.

[Comment 8 Jeroen Roovers (RETIRED) 2014-03-14 14:57:12 UTC]

(In reply to hal from comment #7)
> I'm about to create some patches for each of the affected packages:
> 
> splash-themes-livecd-2005.0.ebuild
> 24:	sed -i -e 's-/sbin/functions.sh-/etc/init.d/functions.sh-'
> scripts/rc_init-pre scripts/list_svc.sh

The gentoo-dev@ mailing lists suggests depending on sys-apps/gentoo-functions, and consequently using </lib/gentoo/functions.sh>. Also, 

> Do want to see patches for the ebuilds to "sed patch" the actual source or
> would you like to see patches for the source applied by epatch?.

Maybe you should not do anything for now. The patches would be trivial anyway.

[Comment 9 Jeroen Roovers (RETIRED) 2014-03-14 15:02:22 UTC]

Also, all of this looks like it's already fixed in 2007.0-r2.

[Comment 10 Jeroen Roovers (RETIRED) 2014-03-14 15:07:35 UTC]

2007.0-r2 installs

image/etc/splash/livecd-2007.0/scripts/rc_init-pre:[ -r /etc/init.d/functions.sh ] && . /etc/init.d/functions.sh

which is the only place where it matters, so that should be fine.

[Comment 11 Michał Górny 2014-12-21 19:12:59 UTC]

<QA hat>

This is a trivial fix that doesn't come with any real backwards compatibility dangers. In fact, it improves safety of packages through replacing implicit dependency on private API of a medium-sized package by explicit dependency on small, dedicated package.

That said, 9 months (1.5yr in case of glibc) to apply the fix is definitely too long. Therefore, I'm setting a deadline on fixing the remaining bugs to 2014-12-27. If the bugs aren't fixed till that point, I will be committing simple 'sed' statements to replace the inherits.

</QA hat>

[Comment 12 Jeroen Roovers (RETIRED) 2014-12-23 08:10:19 UTC]

Just do it.

[Comment 13 Georgi Georgiev 2015-04-16 13:57:39 UTC]

(In reply to Jeroen Roovers from comment #12)
> Just do it.

Yes, please.

[Comment 14 Michał Górny 2016-02-21 11:10:28 UTC]

Merged PR fixing this.