Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 503466 - >=sys-power/upower-0.9.21: make pm-utils an optional dependency
Summary: >=sys-power/upower-0.9.21: make pm-utils an optional dependency
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux bug wranglers
URL: http://cgit.freedesktop.org/upower/co...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-04 23:50 UTC by hal
Modified: 2014-03-18 22:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
USE=pm-utils patch (upower-0.9.23.ebuild.patch,1.73 KB, patch)
2014-03-06 16:56 UTC, hal
Details | Diff
upower-0.9.23.ebuild (upower-0.9.23.ebuild,2.00 KB, text/plain)
2014-03-06 16:57 UTC, hal
Details

Note You need to log in before you can comment on or make changes to this bug.
Description hal 2014-03-04 23:50:42 UTC
Since upstream deprecated pm-utils as a hard dependency since upower-0.9.20 couldn't we make it an option by introducing the pm-utils useflag to the upower ebuild?

Reproducible: Always

Steps to Reproduce:
1. emerge -av upower


Actual Results:  
pulls in pm-utils

Expected Results:  
pm-utils should be optional
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2014-03-05 07:54:52 UTC
no, it shouldn't be optional on non-systemd systems, upower uses either pm-utils or systemd, and we have a USE flag 'systemd' to control this already
the commit message might be a bit vague, don't let it confuse you
Comment 2 hal 2014-03-05 20:07:35 UTC
An exclusive usage of USE=systemd might be confusing.
If I wanted to use upower without pm-utils on a openrc based system it's not intuitive and/or clear why I would have to set USE=systemd in that case.

The point is that there are situations where users have to use upower but do not want or simply can not use pm-utils. Thus they don't need or want pm-utils to be installed on their systems at all.

Into my mind come examples where people would like to use upower without pm-utils:
- Booting from a ssd is so fast that it's not profitable to suspend at all
- Resigned to use suspend because of quirky hardware

Both cases apply to two of my machines. :)
Nevertheless those usecases might require upower for other purposes like shutdown and reboot actions.
Comment 3 hal 2014-03-06 16:56:57 UTC
Created attachment 371888 [details, diff]
USE=pm-utils patch

- Introduces pm-utils IUSE
- "--disable-deprecated" is set as a default
- "--enable-deprecated" is only set if USE=pm-utils is set
- Introduced softblockers for systemd and pm-utils
Comment 4 hal 2014-03-06 16:57:56 UTC
Created attachment 371890 [details]
upower-0.9.23.ebuild

Corresponding ebuild for the patch to make reviewing easier