Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 503220 - [PATCH] llvm 3.4 build fails on darwin and incorrect c include dir everywhere else
Summary: [PATCH] llvm 3.4 build fails on darwin and incorrect c include dir everywhere...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-02 17:04 UTC by Reza Jelveh
Modified: 2015-05-31 10:28 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fixes the build settings, and the darwin issues in the ebuild (llvm-3.4-ebuild-fixes.diff,918 bytes, patch)
2014-03-02 17:06 UTC, Reza Jelveh
Details | Diff
llvm fix the arm build dependency introduced in llvm 3.4 on darwin (llvm-3.4-fix_darwin_build.patch,1.80 KB, patch)
2014-03-02 17:08 UTC, Reza Jelveh
Details | Diff
replaced epatch PN with epatch llvm in build (llvm-3.4-ebuild-fixes.diff,917 bytes, patch)
2014-03-02 17:09 UTC, Reza Jelveh
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Reza Jelveh 2014-03-02 17:04:42 UTC
the llvm 3.4 build fails on darwin. also the c include directories do not include the prefix directory.

Reproducible: Always
Comment 1 Reza Jelveh 2014-03-02 17:06:39 UTC
Created attachment 371572 [details, diff]
fixes the build settings, and the darwin issues in the ebuild
Comment 2 Reza Jelveh 2014-03-02 17:08:21 UTC
Created attachment 371574 [details, diff]
llvm fix the arm build dependency introduced in llvm 3.4 on darwin
Comment 3 Reza Jelveh 2014-03-02 17:09:32 UTC
Created attachment 371576 [details, diff]
replaced epatch PN with epatch llvm in build
Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2014-03-02 17:43:54 UTC
+	# Setup the search path to include the Prefix includes
+	if use prefix ; then
+		conf_flags+=( --with-c-include-dirs=${EPREFIX}/usr/include:/usr/include )
+	fi

Do you *really* need to put that inside a "use prefix" block?
Comment 5 Reza Jelveh 2014-03-02 17:51:49 UTC
(In reply to Jeremy Olexa (darkside) from comment #4)
> +	# Setup the search path to include the Prefix includes
> +	if use prefix ; then
> +		conf_flags+=( --with-c-include-dirs=${EPREFIX}/usr/include:/usr/include )
> +	fi
> 
> Do you *really* need to put that inside a "use prefix" block?

that's how it was in clang-3.3 ebuild before it disappeared. why don't you just suggest how you think it should be done correctly?
Comment 6 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2014-03-02 19:07:14 UTC
I didn't look at the previous versions, sorry.

EPREFIX will get evaluated to "" on Gentoo Linux, so there is not much value in putting it in a special prefix block, assuming we are only prepending EPREFIX to the Gentoo Linux version. Is that correct?
Comment 7 Reza Jelveh 2014-03-02 21:58:24 UTC
(In reply to Jeremy Olexa (darkside) from comment #6)
> I didn't look at the previous versions, sorry.
> 
> EPREFIX will get evaluated to "" on Gentoo Linux, so there is not much value
> in putting it in a special prefix block, assuming we are only prepending
> EPREFIX to the Gentoo Linux version. Is that correct?

ahhh ok. i thought you had something in mind. while what you say is correct i don't think it would be a good thing to do. it will evaluate to "" that is correct, however, i don't think there is any special logic in place to check the search page contains duplicates(personally i don't see a reason why it should). so by leaving out the use prefix check we're essentially polluting the compiler search path. while theoretically nothing will happen, except that it would worst check the path if a file doesn't exist we should refrain from setting it unnecessarily.

anyway, that's just my opinion.
Comment 8 Reza Jelveh 2014-03-02 21:59:03 UTC
(In reply to Jeremy Olexa (darkside) from comment #6)
> I didn't look at the previous versions, sorry.

I think the check got lost when clang was merged into the llvm ebuild.
Comment 9 William Throwe 2014-03-02 23:57:31 UTC
Partial duplicate of bug #502318.  Since this one has discussion and addresses more issues it might be best to duplicate the other way, but I'll leave that to the devs to decide.
Comment 10 Fabian Groffen gentoo-dev 2015-05-31 10:28:41 UTC
I think this got fixed, as we now have a llvm toolchain that is able to bootstrap a system.