Bug 502058 – sys-kernel/hardened-sources-3.13.3-r1 on ARM - /arch/arm/include/asm/atomic.h:716:1: error: no return statement in function returning non-void [-Werror=return-type]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description A. Person 2014-02-21 23:15:06 UTC]

sys-kernel/hardened-sources-3.13.3-r1 fails to build on my Pandaboard ARM device.  I get the below atomic64_sub_return messages throughout the make until it finally fails.  gentoo-sources-3.13.3 works great.  I copied the config to hardened-sources and set up grsecurity before running make.

from include/linux/time.h:5,
from include/linux/stat.h:18,
from include/linux/module.h:10,
from block/cfq-iosched.c:9:
/usr/src/linux-3.13.3-hardened-r1/arch/arm/include/asm/atomic.h: In function ‘atomic64_sub_return’:
/usr/src/linux-3.13.3-hardened-r1/arch/arm/include/asm/atomic.h:716:1: warning: no return statement in function returning non-void [-Wreturn-type]
LD block/built-in.o
CC grsecurity/grsec_chdir.o
In file included from include/linux/atomic.h:4:0,
from include/linux/debug_locks.h:5,
from include/linux/lockdep.h:23,
from include/linux/spinlock_types.h:18,
from include/linux/spinlock.h:81,
from include/linux/seqlock.h:35,
from include/linux/time.h:5,
from include/uapi/linux/timex.h:56,
from include/linux/timex.h:56,
from include/linux/sched.h:17,
from grsecurity/grsec_chdir.c:2:
/usr/src/linux-3.13.3-hardened-r1/arch/arm/include/asm/atomic.h: In function ‘atomic64_sub_return’:
/usr/src/linux-3.13.3-hardened-r1/arch/arm/include/asm/atomic.h:716:1: error: no return statement in function returning non-void [-Werror=return-type]
cc1: all warnings being treated as errors
make[1]: *** [grsecurity/grsec_chdir.o] Error 1
make: *** [grsecurity] Error 2

[Comment 1 Anthony Basile 2014-09-14 00:33:29 UTC]

Is this still an issue in recent kernels?

[Comment 2 PaX Team 2014-09-14 13:27:04 UTC]

i fixed the missing return regression in later patches but i just now noticed that i'm still missing an smp_mb in this function so wait for the next patches please.

[Comment 3 Anthony Basile 2014-11-29 13:30:25 UTC]

(In reply to PaX Team from comment #2)
> i fixed the missing return regression in later patches but i just now
> noticed that i'm still missing an smp_mb in this function so wait for the
> next patches please.

I'm not able to test the hardened-sources kernel on arm.  Can you let me know the status of this bug?

[Comment 4 PaX Team 2014-11-29 22:11:52 UTC]

this was fixed already some time ago.