Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 499940 - x11-misc/xdg-user-dirs-0.15 - build fix to use external libiconv when needed
Summary: x11-misc/xdg-user-dirs-0.15 - build fix to use external libiconv when needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Freedesktop bugs
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 366885
  Show dependency tree
 
Reported: 2014-02-01 02:22 UTC by René Rhéaume
Modified: 2014-03-16 02:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
xdg-user-dirs-0.15-libiconv.patch (xdg-user-dirs-0.15-libiconv.patch,482 bytes, patch)
2014-02-01 02:24 UTC, René Rhéaume
Details | Diff
xdg-user-dirs-0.15.ebuild.patch (file_499940.txt,845 bytes, patch)
2014-02-01 02:28 UTC, René Rhéaume
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description René Rhéaume 2014-02-01 02:22:41 UTC
There used to be a patch for xdg-user-dirs-0.14 that was rejected upstream because  it was also disabling NLS and replacing a function strndup with strdup, which have different semantics. However, the external libiconv part is relevant for uclibc systems (and possibly BSD too) relying on an external iconv implementation. This patch only contains the external iconv support enabling a build on uclibc systems.

Reproducible: Always

Steps to Reproduce:
1. Install lilblue
2. emerge -1 =x11-misc/xdg-user-dirs-0.15
3.
Actual Results:  
emake failed

Expected Results:  
xdg-user-dirs installed on system
Comment 1 René Rhéaume 2014-02-01 02:24:06 UTC
Created attachment 369234 [details, diff]
xdg-user-dirs-0.15-libiconv.patch

External libiconv support patch
Comment 2 René Rhéaume 2014-02-01 02:28:36 UTC
Created attachment 369236 [details, diff]
xdg-user-dirs-0.15.ebuild.patch

Ebuild patch, based on the differences between the 0.14 and the 0.15 ebuild
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2014-03-15 19:38:46 UTC
Is this reported to upstream yet?
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2014-03-15 19:48:00 UTC
patch in portage, please reply to the question about if the patch is sent to upstream yet or not
i'll do that later if you haven't

thanks!
Comment 5 René Rhéaume 2014-03-16 02:23:53 UTC
I neither reported the issue nor sent the patch upstream.