Bug 49893 – Fix compile-errors in evolution-1.4.6 when using gcc-3.4.0

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Alexander Sandbu 2004-05-03 13:40:05 UTC]

Removes some empty defaults: at the end of switch statements

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

[Comment 1 Alexander Sandbu 2004-05-03 13:41:09 UTC]

Created attachment 30636 [details, diff]
Patch for evolution-1.4.6 for gcc-3.4.0

[Comment 2 Jory A. Pratt 2004-05-07 15:23:13 UTC]

I have tested this patch and with no luck .. it still fails.

e-day-view.c:4145: warning: passing arg 1 of `gtk_widget_get_toplevel' from incompatible pointer type
e-day-view.c: In function `e_day_view_on_cut':
e-day-view.c:4282: warning: passing arg 1 of `gtk_widget_get_toplevel' from incompatible pointer type
e-day-view.c: In function `e_day_view_finish_long_event_resize':
e-day-view.c:4918: warning: passing arg 1 of `gtk_widget_get_toplevel' from incompatible pointer type
e-day-view.c:4919: warning: passing arg 1 of `send_component_dialog' from incompatible pointer type
e-day-view.c:4929: warning: passing arg 1 of `gtk_widget_get_toplevel' from incompatible pointer type
e-day-view.c:4930: warning: passing arg 1 of `send_component_dialog' from incompatible pointer type
e-day-view.c: In function `e_day_view_finish_resize':
e-day-view.c:5000: warning: passing arg 1 of `gtk_widget_get_toplevel' from incompatible pointer type
e-day-view.c:5001: warning: passing arg 1 of `send_component_dialog' from incompatible pointer type
e-day-view.c:5011: warning: passing arg 1 of `gtk_widget_get_toplevel' from incompatible pointer type
e-day-view.c:5011: warning: passing arg 1 of `send_component_dialog' from incompatible pointer type
e-day-view.c: In function `e_day_view_on_editing_stopped':
e-day-view.c:6634: warning: passing arg 1 of `gtk_widget_get_toplevel' from incompatible pointer type
e-day-view.c:6635: warning: passing arg 1 of `send_component_dialog' from incompatible pointer type
e-day-view.c:6644: warning: passing arg 1 of `gtk_widget_get_toplevel' from incompatible pointer type
e-day-view.c:6645: warning: passing arg 1 of `send_component_dialog' from incompatible pointer type
e-day-view.c: In function `e_day_view_on_top_canvas_drag_data_received':
e-day-view.c:7750: warning: passing arg 1 of `gtk_widget_get_toplevel' from incompatible pointer type
e-day-view.c:7751: warning: passing arg 1 of `send_component_dialog' from incompatible pointer type
e-day-view.c:7762: warning: passing arg 1 of `gtk_widget_get_toplevel' from incompatible pointer type
e-day-view.c:7763: warning: passing arg 1 of `send_component_dialog' from incompatible pointer type
e-day-view.c: In function `e_day_view_on_main_canvas_drag_data_received':
e-day-view.c:7881: warning: passing arg 1 of `gtk_widget_get_toplevel' from incompatible pointer type
e-day-view.c:7882: warning: passing arg 1 of `send_component_dialog' from incompatible pointer type
e-day-view.c:7893: warning: passing arg 1 of `gtk_widget_get_toplevel' from incompatible pointer type
e-day-view.c:7894: warning: passing arg 1 of `send_component_dialog' from incompatible pointer type
e-day-view.c: In function `selection_received':
e-day-view.c:8081: warning: passing arg 1 of `gtk_widget_get_toplevel' from incompatible pointer type
e-day-view.c:8081: warning: passing arg 1 of `send_component_dialog' from incompatible pointer type
make[4]: *** [e-day-view.lo] Error 1
make[4]: Leaving directory `/var/tmp/portage/evolution-1.4.6/work/evolution-1.4.6/calendar/gui'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/var/tmp/portage/evolution-1.4.6/work/evolution-1.4.6/calendar/gui'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/var/tmp/portage/evolution-1.4.6/work/evolution-1.4.6/calendar'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/evolution-1.4.6/work/evolution-1.4.6'
make: *** [all-recursive-am] Error 2

[Comment 3 Alexander Sandbu 2004-05-18 04:09:13 UTC]

Created attachment 31646 [details, diff]
New patch, replaces old one

Sorry, one of the files slipped past me

[Comment 4 Jory A. Pratt 2004-05-21 08:04:10 UTC]

Just so you know you shouldn't have the patch delete default; you should change the patch to add back the default; but add break; after that, this will prevent an  abundant scrolling of warnings.

[Comment 5 Tamran Lengyel 2004-05-23 00:25:36 UTC]

Created attachment 31878 [details, diff]
This one is an alternative patch.  I, of course, recommend mine :).

[Comment 6 Travis Tilley (RETIRED) 2004-05-29 20:46:52 UTC]

fixed in cvs. sorry it took so long.