Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 498834 - app-misc/task-2.3.0 version bump
Summary: app-misc/task-2.3.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 2 votes (vote)
Assignee: Tim Harder
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-21 20:24 UTC by Renato Alves
Modified: 2014-08-31 15:35 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild changes between 2.2.0 and 2.3.0 (task-2.3.0.ebuild.patch,347 bytes, patch)
2014-01-21 23:22 UTC, Renato Alves
Details | Diff
rc directory changes for backwards compatibility with 2.2.0 (task-2.3.0-rcdir.patch,1.76 KB, patch)
2014-01-21 23:24 UTC, Renato Alves
Details | Diff
Patch for task-2.3.0.ebuild (task-2.3.0.patch,523 bytes, patch)
2014-01-22 21:15 UTC, Elias Probst
Details | Diff
Patch for task-2.3.0.ebuild (task-2.3.0.patch,614 bytes, patch)
2014-01-22 23:29 UTC, Elias Probst
Details | Diff
Patch for addressing the rcdir issue from issue#1473 (task-2.3.0-issue-1473-rcdir-fix.patch,1.13 KB, patch)
2014-01-22 23:30 UTC, Elias Probst
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Renato Alves 2014-01-21 20:24:50 UTC
Version 2.3.0 is available since 15-01-2014

http://taskwarrior.org/projects/taskwarrior/wiki/Download

Taskwarrior 2.3.0 is now also able to interact with a Task Server "taskd" by the same team of developers.

Should a new bug be open for a package called "app-misc/taskd" version 1.0.0?

Reproducible: Always
Comment 1 Renato Alves 2014-01-21 23:22:38 UTC
Created attachment 368406 [details, diff]
Ebuild changes between 2.2.0 and 2.3.0
Comment 2 Renato Alves 2014-01-21 23:24:08 UTC
Created attachment 368408 [details, diff]
rc directory changes for backwards compatibility with 2.2.0

There was a slight change in the CMakefile that required a new patch instead of the existing for task-2.0.0-beta4
Comment 3 Renato Alves 2014-01-21 23:31:02 UTC
Apart from the changes in the attached files, main features work as expected.

The new task server related features (pull, push, merge, synchronize) were not tested.
Comment 4 Elias Probst 2014-01-22 21:15:59 UTC
Created attachment 368458 [details, diff]
Patch for task-2.3.0.ebuild

I created a bump to 2.3.0 more or less at the same time as you, but did some things differently.

Instead of patching around RCDIR, it is way easier to use it as described in the INSTALL file. All dirs are automatically prepended by CMAKE_INSTALL_PREFIX, so all definitions (TASK_{BIN,DOC,RC,MAN1,MAN5}DIR) need to be relative and not absolute.

This boils down to simply fixing the usage of TASK_DOCDIR in the ebuild:

-               -DTASK_DOCDIR="${EPREFIX}"/usr/share/doc/${PF}
+               -DTASK_DOCDIR=share/doc/${PF}

Besides that, the rcdir-patch can be removed now, as this issue was fixed upstream in http://taskwarrior.org/issues/1473

The result is the attached diff which is enough to make it work properly after bumping the ebuild to 2.3.0.
Comment 5 Elias Probst 2014-01-22 23:29:08 UTC
Created attachment 368486 [details, diff]
Patch for task-2.3.0.ebuild

It turns out upstream missed a tiny detail in issue#1473 - doc/CmakeLists.txt still used TASK_DOCDIR to install the rc subdirectory which caused all the themefiles to still end up in TASK_DOCDIR and being compressed by Portage.

The current version of this patch addresses this issue - the required patch will be added next and was provided upstream in issue#1473.
Comment 6 Elias Probst 2014-01-22 23:30:16 UTC
Created attachment 368488 [details, diff]
Patch for addressing the rcdir issue from issue#1473
Comment 7 Ondrej Grover 2014-05-17 12:39:36 UTC
Just tested the new ebuild (applied patch and downloaded the other patch) on amd64 and it builds and works fine.
Comment 8 Tiziano Müller (RETIRED) gentoo-dev 2014-08-31 15:35:55 UTC
committed, thanks!