Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 498212 - sys-libs/e2fsprogs-libs: please review prefix changes
Summary: sys-libs/e2fsprogs-libs: please review prefix changes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: Inclusion, PATCH
Depends on:
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2014-01-15 23:14 UTC by Christoph Junghans (RETIRED)
Modified: 2014-01-17 15:59 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
patch against e2fsprogs-libs-1.42.9.ebuild (e2fsprogs-libs-1.42.9.ebuild.patch,1.01 KB, patch)
2014-01-15 23:14 UTC, Christoph Junghans (RETIRED) 		Details | Diff
patch against e2fsprogs-libs-1.42.9.ebuild (e2fsprogs-libs-1.42.9.ebuild.patch,815 bytes, patch)
2014-01-16 18:48 UTC, Christoph Junghans (RETIRED) 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Junghans (RETIRED) gentoo-dev 2014-01-15 23:14:45 UTC 
Created attachment 367918 [details, diff]
patch against e2fsprogs-libs-1.42.9.ebuild

Changes (trivial):
- mint doesn't need a libtype
- fix defines for uuid on mint
Comment 1 SpanKY gentoo-dev 2014-01-16 01:41:44 UTC 
Comment on attachment 367918 [details, diff]
patch against e2fsprogs-libs-1.42.9.ebuild

>+	if [[ ${CHOST} == *-mint* ]]; then
>+		sed -i -e 's/_SVID_SOURCE/_GNU_SOURCE/' lib/uuid/gen_uuid.c || die
>+	fi

this needs documentation.  there's no details at all here.

> 	case ${CHOST} in
>-		*-darwin*) libtype=bsd;;
>-		*)         libtype=elf;;
>+		*-darwin*) libtype=--enable-bsd-shlibs  ;;
>+		*-mint*)   libtype=                     ;;
>+		*)         libtype=--enable-elf-shlibs  ;;

this is the point of the tc-is-static-only func.  don't hardcode mint here.
Comment 2 Alan Hourihane 2014-01-16 18:09:19 UTC 
(In reply to SpanKY from comment #1)
> Comment on attachment 367918 [details, diff] [details, diff]
> patch against e2fsprogs-libs-1.42.9.ebuild
> 
> >+	if [[ ${CHOST} == *-mint* ]]; then
> >+		sed -i -e 's/_SVID_SOURCE/_GNU_SOURCE/' lib/uuid/gen_uuid.c || die
> >+	fi

This part is no longer required and can be removed.
Comment 3 Christoph Junghans (RETIRED) gentoo-dev 2014-01-16 18:26:11 UTC 
(In reply to SpanKY from comment #1)
> this needs documentation.  there's no details at all here.
> 
> > 	case ${CHOST} in
> >-		*-darwin*) libtype=bsd;;
> >-		*)         libtype=elf;;
> >+		*-darwin*) libtype=--enable-bsd-shlibs  ;;
> >+		*-mint*)   libtype=                     ;;
> >+		*)         libtype=--enable-elf-shlibs  ;;
> 
> this is the point of the tc-is-static-only func.  don't hardcode mint here.
@alan, can you comment on the use of tc-is-static-only?

According to grobian the darwin part might not be need anymore, too.
Comment 4 Alan Hourihane 2014-01-16 18:35:33 UTC 
It just needs this then....

$(tc-is-static-only || echo --enable-elf-shlibs)

On the actual econf build line.
Comment 5 Christoph Junghans (RETIRED) gentoo-dev 2014-01-16 18:48:08 UTC 
Created attachment 367964 [details, diff]
patch against e2fsprogs-libs-1.42.9.ebuild

(In reply to Alan Hourihane from comment #4)
> It just needs this then....
> 
> $(tc-is-static-only || echo --enable-elf-shlibs)
> 
> On the actual econf build line.
Great, here we go.
Comment 6 SpanKY gentoo-dev 2014-01-17 02:45:50 UTC 
Comment on attachment 367964 [details, diff]
patch against e2fsprogs-libs-1.42.9.ebuild

LGTM; feel free to commit
Comment 7 Christoph Junghans (RETIRED) gentoo-dev 2014-01-17 15:59:30 UTC 
+  17 Jan 2014; Christoph Junghans <ottxor@gentoo.org>
+  e2fsprogs-libs-1.42.9.ebuild:
+  added prefix support (bug #498212)