Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 497378 - epatch_user: support patches ending in .diff
Summary: epatch_user: support patches ending in .diff
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-07 11:39 UTC by Joerg Bornkessel
Modified: 2016-06-22 15:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joerg Bornkessel gentoo-dev 2014-01-07 11:39:47 UTC
in the moment all patches applied from function epatch_user (eutils.eclass) have to ending on .patch

for most users it is unclear, without reading documentation, on what suffix has the own patches to end

most suffixes for user patches ending on .patch or .diff
i think suffix .diff is more popular for patches

is it possible to expand the EPATCH_SUFFIX="" to use also diff as patch.suffix

Iam not shure, who is the syntax then in the eutils.eclass

possible would be in function epatch_user()

<snipp>
+    for xy in diff patch; do
+        xy=epatch_suffix
+    done

-EPATCH_SUFFIX="patch"
+EPATCH_SUFFIX="${epatch_suffix}"
</snapp>

it works here on localy with patches ending on .patch or .diff
what iam not tested is
when in the local patch dir 
both suffixes (.patch and .diff) available

regards
Comment 1 Joerg Bornkessel gentoo-dev 2014-01-07 11:53:26 UTC
(In reply to Joerg Bornkessel from comment #0)

> it works here on localy with patches ending on .patch or .diff
> what iam not tested is
> when in the local patch dir 
> both suffixes (.patch and .diff) available
 
tested also with 2 patches ending on suffix .patch and .diff
works for me
Comment 2 SpanKY gentoo-dev 2016-06-22 15:00:03 UTC
doesn't seem like its been changed