Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 492942 - x11-drivers/xf86-video-virtualbox should be built against Xorg headers rather than bundled headers
Summary: x11-drivers/xf86-video-virtualbox should be built against Xorg headers rather...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alessio Cassibba (X-Drum)
URL: https://www.virtualbox.org/changeset/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-30 11:35 UTC by Walter Meinl
Modified: 2013-11-30 18:23 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for the xf86-video-virtualbox-4.3.2 ebuild (xf86-v-vbox-xorg-headers.patch,1.60 KB, patch)
2013-11-30 11:44 UTC, Walter Meinl
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Walter Meinl 2013-11-30 11:35:01 UTC
Fedora's developpers requested (because of their policy to not include third-party headers in sources) quite a while ago at virtualbox.org that the xf86-video-virtualbox driver should be buildable against the system-Xorg headers.
This comes in quite handy especially when Xorg-server is bumped up.
Currently xf86-video-virtualbox is restricted to a certain top level version of Xorg-server since it usually takes quite a while until the Xorg-headers are imported to the source code of virtualbox.

Reproducible: Always
Comment 1 Walter Meinl 2013-11-30 11:44:20 UTC
Created attachment 364262 [details, diff]
patch for the xf86-video-virtualbox-4.3.2 ebuild

The changeset of Virtualbox that makes it possible to use the Xorg-headers is posted above. Using the define VBOX_USE_SYSTEM_XORG_HEADERS=1 during compilation of the driver results in a file named vboxvideo_drv_system.so that in turn will finally renamed to vboxvideo_drv.so. All the former xorg-version related drivers aren't built anymor when compiling with the define mentioned.
According to the changeset of Virtualbox all versions >=xorg-server-1.7 should work. Since the driver should be recompiled when the xorg-server version is bumped, I added ":=" behind the xorg-server-version, but I am not sure whether this is correct.
With this ebuild I am running successfully x11-base/xorg-server-1.14.99.903 that was unmasked yesterday.
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2013-11-30 18:23:03 UTC
+*xf86-video-virtualbox-4.3.4 (30 Nov 2013)
+
+  30 Nov 2013; Lars Wendler <polynomial-c@gentoo.org>
+  xf86-video-virtualbox-4.2.20.ebuild, -xf86-video-virtualbox-4.3.0.ebuild,
+  +xf86-video-virtualbox-4.3.4.ebuild:
+  Version bump. Removed old. Let the driver compile against system xorg
+  headers. Thanks to Walter Meinl for the bug report and providing a patch in
+  bug #492942.
+

Thanks :)