Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 492936 - app-emulation/pcsxr - PCSX-Reloaded: a fork of PCSX, the discontinued Playstation emulator
Summary: app-emulation/pcsxr - PCSX-Reloaded: a fork of PCSX, the discontinued Playsta...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: Normal enhancement (vote)
Assignee: Michał Górny
URL: http://pcsxr.codeplex.com
Whiteboard:
Keywords:
: 282363 (view as bug list)
Depends on: 493652
Blocks:
  Show dependency tree
 
Reported: 2013-11-30 10:21 UTC by Andrey Aleksandrovich
Modified: 2013-12-12 20:18 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
pcsxr-1.9.93.ebuild (pcsxr-1.9.93.ebuild,1.61 KB, text/plain)
2013-11-30 10:21 UTC, Andrey Aleksandrovich
Details
My ebuild (pcsxr-1.9.94.ebuild,1.72 KB, text/plain)
2013-12-08 13:16 UTC, Michał Górny
Details
Ebuild v2 (pcsxr-1.9.94.ebuild,1.86 KB, text/plain)
2013-12-08 17:05 UTC, Michał Górny
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Aleksandrovich 2013-11-30 10:21:00 UTC
Created attachment 364252 [details]
pcsxr-1.9.93.ebuild

PCSX-Reloaded: a fork of PCSX, the discontinued Playstation emulator.

I take that https://github.com/UnixHub/UnixHub-Portage/blob/master/games-emulation/pcsxr/pcsxr-1.9.93.ebuild as source, but it was needed some changes:
- x11-libs/gtk+
+ >=x11-libs/gtk+-3.0

-for i in $(grep -irl 'games/psemu' *);
-       do
-               sed -i "$i" \
-               -e "s:games/psemu:psemu:g" \
-               || die "sed failed"
-       done

Now it seems to be working :)
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-12-05 11:40:51 UTC
@games: mind if I take it?
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-12-08 13:16:51 UTC
Created attachment 364932 [details]
My ebuild

Here's my ebuild that I'm mostly likely going to commit in a few hours. I'd prefer seeing proper SDL2 or virtual for SDL first, though.
Comment 3 Julian Ospald 2013-12-08 15:27:35 UTC
(In reply to Michał Górny from comment #2)
> Created attachment 364932 [details]
> My ebuild
> 
> Here's my ebuild that I'm mostly likely going to commit in a few hours. I'd
> prefer seeing proper SDL2 or virtual for SDL first, though.

* this will not set any games permissions
* empty useflag list for libsdl is _very_ uncommon, you should double check that it works with all libsdl useflags disabled
* looks like abuse of REQUIRED_USE, although this is not a library
* description and homepage are both empty
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-12-08 17:05:30 UTC
Created attachment 364952 [details]
Ebuild v2

Does anyone know a decent way of getting tarballs out of codeplex?
Comment 5 Andrey Aleksandrovich 2013-12-09 10:16:44 UTC
(In reply to Michał Górny from comment #4)
> Created attachment 364952 [details]
> Ebuild v2
> Does anyone know a decent way of getting tarballs out of codeplex?
That site is not 'bot-friendly' (captcha, waiting). So, your 'SRC_URI="${P}.zip"' doesn't have any sense.
The only way is the 'manual fetching' - http://www.gentoo-wiki.info/FAQ_Fetch_Restrictions
And don't forget that .zip snapshots doesn't save permission attributes of including files.
Comment 6 Julian Ospald 2013-12-11 15:46:51 UTC
these directories/files do not adhere to games.eclass or FHS:

/usr/lib64/games/psemu
/usr/share/games/pixmaps/pcsxr-icon.png
/usr/share/games/applications/pcsxr.desktop
Comment 7 Julian Ospald 2013-12-11 15:51:24 UTC
/usr/games/share/locale

as well
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-12-11 15:53:19 UTC
(In reply to Julian Ospald (hasufell) from comment #6)
> these directories/files do not adhere to games.eclass or FHS:
> 
> /usr/lib64/games/psemu

Does it make sense to use /usr/games/lib64/games? 

> /usr/share/games/pixmaps/pcsxr-icon.png
> /usr/share/games/applications/pcsxr.desktop

I'm in process of fixing the build system. Or rather, waiting for codeplex confirmation mail but I guess Microsoft fails at sending non-spam mails as well.
Comment 9 Julian Ospald 2013-12-11 15:58:03 UTC
(In reply to Michał Górny from comment #8)
> (In reply to Julian Ospald (hasufell) from comment #6)
> > these directories/files do not adhere to games.eclass or FHS:
> > 
> > /usr/lib64/games/psemu
> 
> Does it make sense to use /usr/games/lib64/games? 

It is defined in the eclass as:
"${GAMES_PREFIX}/$(get_libdir)"

which defaults to
/usr/games/lib64

subdirectories are ok, but that rather looks like /usr/games/lib64/${PN}

> 
> > /usr/share/games/pixmaps/pcsxr-icon.png
> > /usr/share/games/applications/pcsxr.desktop
> 
> I'm in process of fixing the build system. Or rather, waiting for codeplex
> confirmation mail but I guess Microsoft fails at sending non-spam mails as
> well.

you could probably copy-paste a few bits from games-board/xboard/files/xboard-4.7.2-paths.patch
Comment 10 Julian Ospald 2013-12-11 16:05:18 UTC
./configure --help | grep ccdda

seems to yield nothing
Comment 11 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-12-11 16:30:24 UTC
(In reply to Julian Ospald (hasufell) from comment #9)
> > > /usr/share/games/pixmaps/pcsxr-icon.png
> > > /usr/share/games/applications/pcsxr.desktop
> > 
> > I'm in process of fixing the build system. Or rather, waiting for codeplex
> > confirmation mail but I guess Microsoft fails at sending non-spam mails as
> > well.
> 
> you could probably copy-paste a few bits from
> games-board/xboard/files/xboard-4.7.2-paths.patch

That patch is unnecessarily complex, and has wrong defaults. Nowadays you should just use datarootdir [1].

[1]:https://www.gnu.org/software/autoconf/manual/autoconf-2.64/html_node/Changed-Directory-Variables.html

(In reply to Julian Ospald (hasufell) from comment #10)
> ./configure --help | grep ccdda
> 
> seems to yield nothing

$ ./configure --help | grep ccdda
  --enable-ccdda         support for compressed CDDA formats via ffmpeg (default=no)
$ grep ccdda configure.ac
AC_ARG_ENABLE(ccdda, [  --enable-ccdda         support for compressed CDDA formats via ffmpeg (default=no)],

Are you grepping the correct package? it's 1.9.94 now (you need to go through 'downloads' and select the newer version on the right hand side).
Comment 12 Julian Ospald 2013-12-11 16:36:45 UTC
(In reply to Michał Górny from comment #11)
> (In reply to Julian Ospald (hasufell) from comment #9)
> > > > /usr/share/games/pixmaps/pcsxr-icon.png
> > > > /usr/share/games/applications/pcsxr.desktop
> > > 
> > > I'm in process of fixing the build system. Or rather, waiting for codeplex
> > > confirmation mail but I guess Microsoft fails at sending non-spam mails as
> > > well.
> > 
> > you could probably copy-paste a few bits from
> > games-board/xboard/files/xboard-4.7.2-paths.patch
> 
> That patch is unnecessarily complex, and has wrong defaults. Nowadays you
> should just use datarootdir [1].
> 
> [1]:https://www.gnu.org/software/autoconf/manual/autoconf-2.64/html_node/
> Changed-Directory-Variables.html
> 

I don't understand how that makes the defaults "wrong".

> (In reply to Julian Ospald (hasufell) from comment #10)
> > ./configure --help | grep ccdda
> > 
> > seems to yield nothing
> 
> $ ./configure --help | grep ccdda
>   --enable-ccdda         support for compressed CDDA formats via ffmpeg
> (default=no)
> $ grep ccdda configure.ac
> AC_ARG_ENABLE(ccdda, [  --enable-ccdda         support for compressed CDDA
> formats via ffmpeg (default=no)],
> 
> Are you grepping the correct package? it's 1.9.94 now (you need to go
> through 'downloads' and select the newer version on the right hand side).

Right, I was testing 93
Comment 13 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-12-11 18:32:32 UTC
Committed after a few more review rounds on #gentoo-games.

+*pcsxr-1.9.94 (11 Dec 2013)
+
+  11 Dec 2013; Michał Górny <mgorny@gentoo.org>
+  +files/pcsxr-1.9.94-disable-sdl2.patch,
+  +files/pcsxr-1.9.94-install-paths.patch, +metadata.xml, +pcsxr-1.9.94.ebuild:
+  Introduce an ebuild for pcsxr, the forked PSX emu. Bug #492936.
Comment 14 Julian Ospald 2013-12-11 18:42:34 UTC
I still get

/usr/games/share/applications/pcsxr.desktop
/usr/games/share/pixmaps/pcsxr-icon.png
/usr/games/share/locale/fr_FR
Comment 15 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-12-11 19:07:24 UTC
+  11 Dec 2013; Michał Górny <mgorny@gentoo.org> pcsxr-1.9.94.ebuild:
+  Pass missing --datarootdir.

Fixed and opened bug against the eclass.
Comment 16 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-12-11 20:04:07 UTC
*** Bug 282363 has been marked as a duplicate of this bug. ***
Comment 17 Andrey Aleksandrovich 2013-12-12 09:02:48 UTC
(In reply to Michał Górny from comment #4)
> Does anyone know a decent way of getting tarballs out of codeplex?
http://pcsxr.codeplex.com/site/legal/privacy
© 2006-2013 Microsoft

Just to note.
Comment 18 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-12-12 17:36:26 UTC
(In reply to Andrey Aleksandrovich from comment #17)
> (In reply to Michał Górny from comment #4)
> > Does anyone know a decent way of getting tarballs out of codeplex?
> http://pcsxr.codeplex.com/site/legal/privacy
> © 2006-2013 Microsoft
> 
> Just to note.

Yes, I've noticed. I'm also wondering if that's the reason I'm not getting activation e-mail for my new account there.
Comment 19 Andrey Aleksandrovich 2013-12-12 20:18:33 UTC
Anyway, the code is GNU/GPL'ed, so it's possible to make another 'bot-friendly' repository, which would be specified as $SRC_URI.