Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 492792 - sci-geosciences/gmt-5.4.2 version bump
Summary: sci-geosciences/gmt-5.4.2 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 4 votes (vote)
Assignee: Sci-geo Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 561202
  Show dependency tree
 
Reported: 2013-11-28 13:14 UTC by Thomas Beutin
Modified: 2020-02-18 09:09 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild for 5.2.1 (gmt-5.2.1.ebuild,1.57 KB, text/plain)
2016-01-04 01:28 UTC, Joe Sapp (RETIRED)
Details
gmt-5.2.1.ebuild (gmt-5.2.1.ebuild,1.56 KB, text/plain)
2016-03-01 03:50 UTC, Sam Jorna (wraeth)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Beutin 2013-11-28 13:14:26 UTC
According to http://gmt.soest.hawaii.edu/ the current version of sci-geosciences/gmt id 5.1.0

Reproducible: Always




according to 
http://gmt.soest.hawaii.edu/doc/5.1.0/GMT_Docs.html#switching-between-different-gmt-versions
"We encourage all GMT users to start using version 5 immediately; it has been tested extensively by the GMT team and has benefitted from bug reports for the 4.5.x versions. Users who still worry about the new version breaking things may install GMT 4.5.x and 5 side by side."

Maybe this is a candidate for slotting?
Comment 1 Tomas Psika 2014-05-31 21:51:27 UTC
sci-geosciences/gmt-5.1.0 -> sci-geosciences/gmt-5.1.1
Comment 2 Thomas Beutin 2015-04-20 14:01:01 UTC
According to http://gmt.soest.hawaii.edu/ they released GMT-4.5.13 (2015-01-01).
Comment 3 Thomas Beutin 2015-05-19 04:43:36 UTC
(In reply to Thomas Beutin from comment #2)
> According to http://gmt.soest.hawaii.edu/ they released GMT-4.5.13
> (2015-01-01).

According to http://gmt.soest.hawaii.edu/ they released GMT-5.1.2 (2015-05-04).
Comment 4 Joe Sapp (RETIRED) gentoo-dev 2016-01-03 20:02:56 UTC
I'll work on this if nobody else has done so.  It won't have slotting, but at least there will be the option for GMT 5.
Comment 5 Joe Sapp (RETIRED) gentoo-dev 2016-01-04 01:28:29 UTC
Created attachment 421832 [details]
ebuild for 5.2.1

Proposed ebuild for latest version of GMT. Please test and provide feedback/improve!
Comment 6 Sam Jorna (wraeth) gentoo-dev 2016-01-10 09:16:08 UTC
This ebuild builds and installs fine for me.

Running repoman across the ebuild identifies the following issues:

>  IUSE.invalid [fatal]          2
>   sci-geosciences/gmt/gmt-5.2.1.ebuild: gpl
>   sci-geosciences/gmt/gmt-5.2.1.ebuild: lgpl

These flags, which appear to restrict features within the build, will need to be added to metadata.xml.

>  LICENSE.invalid [fatal]       3
>   sci-geosciences/gmt/gmt-5.2.1.ebuild: !gpl
>   sci-geosciences/gmt/gmt-5.2.1.ebuild: !lgpl
>   sci-geosciences/gmt/gmt-5.2.1.ebuild: Shewchuk

I'm not sure how this license stanza is meant to be interpreted (specifically the "( !gpl !lgpl )")

> LICENSE="LGPL-3 gpl? ( GPL-3 ) ( !gpl !lgpl ) Shewchuk"

This also includes the introduction of a new license that is not present in /usr/portage/licenses.

From LICENSE.TXT:

> NOTE: Some of the source files in src/ have different licenses.  For
> instance Shewchuk's Delaunay Triangulator (triangle.c) is distributed
> under a proprietary non-permissive license. Refer to the license in
> every source file. Users who wish to enforce strict GPL or LGPL
> conformance are advised to exclude copylefted sources in
> cmake/ConfigUser.cmake.
Comment 7 Joe Sapp (RETIRED) gentoo-dev 2016-01-10 19:56:26 UTC
Thanks for the feedback.

(In reply to Sam Jorna (wraeth) from comment #6)
> This ebuild builds and installs fine for me.
> 
> Running repoman across the ebuild identifies the following issues:
> 
> >  IUSE.invalid [fatal]          2
> >   sci-geosciences/gmt/gmt-5.2.1.ebuild: gpl
> >   sci-geosciences/gmt/gmt-5.2.1.ebuild: lgpl
> 
> These flags, which appear to restrict features within the build, will need
> to be added to metadata.xml.

Will do.  I have added them locally in order to specify that certain parts of the code are compiled.  See next item...

> >  LICENSE.invalid [fatal]       3
> >   sci-geosciences/gmt/gmt-5.2.1.ebuild: !gpl
> >   sci-geosciences/gmt/gmt-5.2.1.ebuild: !lgpl
> >   sci-geosciences/gmt/gmt-5.2.1.ebuild: Shewchuk
> 
> I'm not sure how this license stanza is meant to be interpreted
> (specifically the "( !gpl !lgpl )")
> 
> > LICENSE="LGPL-3 gpl? ( GPL-3 ) ( !gpl !lgpl ) Shewchuk"

I'll have to work on this a bit.  The idea was that if you only wanted GPL or LGPL code, you would enable at most one of those USE flags.  If you didn't care or agree to the below license, you can disable both.  Any thoughts on a clearer presentation?

> This also includes the introduction of a new license that is not present in
> /usr/portage/licenses.
> 
> From LICENSE.TXT:
> 
> > NOTE: Some of the source files in src/ have different licenses.  For
> > instance Shewchuk's Delaunay Triangulator (triangle.c) is distributed
> > under a proprietary non-permissive license. Refer to the license in
> > every source file. Users who wish to enforce strict GPL or LGPL
> > conformance are advised to exclude copylefted sources in
> > cmake/ConfigUser.cmake.

This would be done by setting USE="gpl" or USE="lgpl".  Of course I would also add the text from these files into the "Shewchuk" license.

Thanks for reminding me to check with repoman!
Comment 8 Sam Jorna (wraeth) gentoo-dev 2016-03-01 03:50:42 UTC
Created attachment 427064 [details]
gmt-5.2.1.ebuild

I've reworked the ebuild from attachment 421832 [details] a little with the following changes:

 - bumped to EAPI6
 - removed multilib support (see below)
 - define LICENSE as I understand it's supposed to be applied
 - reorder RDEPEND
 - clean up unnecessary subshell calls
 - add missing '|| die's

With the removal of multilib support, while the ebuild inherits and calls multilib phases, it didn't actually provide an ABI USE flag to be used, and when I tried to convert it to proper multilib it required conversion of a number of deps (sci-libs/hdf, sci-libs/hdf5, sci-libs/netcdf, sci-libs/gdal - I stopped there). It's also worth noting that this doesn't have any apparent reverse dependencies, so multilib shouldn't be required.

Proper multilib support can be added back in if required, but it will need a number of other packages converted in order to do so.

Otherwise, unless there are any objections (is LICENSE set out the way you intended it to be?), I think this should be able to be committed once the addition of the Shewchuk license is clarified.
Comment 9 Sam Jorna (wraeth) gentoo-dev 2016-03-01 04:08:10 UTC
It's also worth considering bug 430028 - this package downloads and makes use of GSHHG, whereas sci-geosciences/gshhs (a subset of GSHHG) already exists in the tree. Perhaps this could be used (and/or updated) instead of downloading redundant information and potentially causing file collisions.
Comment 10 Thomas Beutin 2016-09-11 20:53:13 UTC
(In reply to Sam Jorna (wraeth) from comment #8)
> Created attachment 427064 [details]
> gmt-5.2.1.ebuild

Hi, is the any reason why this is not in the portage tree yet?
Comment 11 Joe Sapp (RETIRED) gentoo-dev 2016-09-13 00:52:12 UTC
(In reply to Thomas Beutin from comment #10)
> (In reply to Sam Jorna (wraeth) from comment #8)
> > Created attachment 427064 [details]
> > gmt-5.2.1.ebuild
> 
> Hi, is the any reason why this is not in the portage tree yet?

See comment #9...I think that bug is a blocker.  I also forgot about this since then :)
Comment 12 Thomas Beutin 2017-07-06 06:43:16 UTC
According to
ftp://ftp.star.nesdis.noaa.gov/pub/sod/lsa/gmt/README.GMT
5.4.2 and 4.5.16 of GMT have recently been released
($Id: README.GMT 10386 2017-06-20 03:12:50Z pwessel $)
Comment 13 Thomas Beutin 2018-07-10 14:59:24 UTC
According to
ftp://ftp.star.nesdis.noaa.gov/pub/sod/lsa/gmt/README.GMT
5.4.4 and 4.5.18 of GMT have recently been released
($Id: README.GMT 10410 2018-06-22 18:51:42Z pwessel $)
Comment 14 Martin von Gagern 2018-11-03 23:22:33 UTC
While I agree that duplicate information and potential file collisions are ugly, I don't see that as a blocker which should keep ebuilds out of portage for years. It should be easy enough to declare a blocker on sci-geosciences/gshhs-data to avoid file collisions at the cost of preventing concurrent installations. Then if concurrent installs are needed by some users, perhaps they will lend a hand here.
Comment 15 Michael Uleysky 2018-12-05 14:13:26 UTC
I place ebuilds for gmt-4.5.18, gmt-5.4.4 and gmt-9999 in gsview overlay. There is also a pull request (https://github.com/gentoo/gentoo/pull/9645) to include them in the main tree.
Comment 16 Andreas Sturmlechner gentoo-dev 2020-02-16 17:42:03 UTC
Bumped in commit ec3bf8a6ee69aea6be83b2197915763c9962d505, thank you very much Michael.
Comment 17 Thomas Beutin 2020-02-18 09:09:03 UTC
Thanks a lot, Michael!