Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 492764 - media-sound/gqradio-1.9.2 doesn't explicitly link with libX11
Summary: media-sound/gqradio-1.9.2 doesn't explicitly link with libX11
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: underlinking
  Show dependency tree
 
Reported: 2013-11-28 03:23 UTC by Geoff Madden
Modified: 2014-02-02 09:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge info (emerge.inf,5.09 KB, text/plain)
2013-11-28 03:27 UTC, Geoff Madden
Details
build log for gqradio (build.log,60.82 KB, application/octet-stream)
2013-11-28 03:27 UTC, Geoff Madden
Details
gqradio-1.9.2-underlinking.patch (gqradio-1.9.2-underlinking.patch,642 bytes, patch)
2014-01-29 12:54 UTC, Ted Tanberry
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoff Madden 2013-11-28 03:23:23 UTC
-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lfontconfig -lfreetype  
/usr/lib/gcc/x86_64-pc-linux-gnu/4.8.2/../../../../x86_64-pc-linux-gnu/bin/ld: ui2_util.o: undefined reference to symbol 'XInternAtom'
/usr/lib/gcc/x86_64-pc-linux-gnu/4.8.2/../../../../x86_64-pc-linux-gnu/bin/ld: note: 'XInternAtom' is defined in DSO /usr/lib64/libX11.so.6 so try adding it to the linker command line
/usr/lib64/libX11.so.6: could not read symbols: Invalid operation
collect2: error: ld returned 1 exit status
Makefile:373: recipe for target 'gqradio' failed
make[3]: *** [gqradio] Error 1
make[3]: Leaving directory '/var/tmp/portage/media-sound/gqradio-1.9.2/work/gqradio-1.9.2/src'
Makefile:453: recipe for target 'all-recursive' failed
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory '/var/tmp/portage/media-sound/gqradio-1.9.2/work/gqradio-1.9.2/src'
Makefile:331: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/media-sound/gqradio-1.9.2/work/gqradio-1.9.2'
Makefile:199: recipe for target 'all' failed
make: *** [all] Error 2
emake failed
 * 

Reproducible: Always

Steps to Reproduce:
1.emerge
2.build
3.fail    I did add libX11 into the ebuild but not successful
Actual Results:  
build failed in both cases

Expected Results:  
completed build
Comment 1 Geoff Madden 2013-11-28 03:27:02 UTC
Created attachment 364120 [details]
emerge info
Comment 2 Geoff Madden 2013-11-28 03:27:56 UTC
Created attachment 364122 [details]
build log for gqradio
Comment 3 Geoff Madden 2013-11-28 03:31:45 UTC
can any one point me to the right area to add this into ldconfig,there appears to be no x11 stuff in env.d
geoff
Comment 4 Rafał Mużyło 2013-11-28 09:43:18 UTC
(In reply to Geoff Madden from comment #3)
> can any one point me to the right area to add this into ldconfig,there
> appears to be no x11 stuff in env.d

That would be the *wrong* solution.
AFAICT, the problem here is simply that binutils 2.23 is bit more strict about things and gqradio fails to link to libX11 directly.
Comment 5 Ted Tanberry 2014-01-29 12:53:40 UTC
--- gqradio-1.9.2.ebuild
+++ gqradio-1.9.2.ebuild
@@ -2,7 +2,8 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /var/cvsroot/gentoo-x86/media-sound/gqradio/gqradio-1.9.2.ebuild,v 1.5 2012/05/05 08:27:48 mgorny Exp $
 
-EAPI=2
+EAPI=5
+inherit autotools eutils
 
 DESCRIPTION="An FM radio tuner app from the people who brought you GQmpeg."
 HOMEPAGE="http://gqmpeg.sourceforge.net/radio.html"
@@ -18,6 +19,11 @@
        virtual/pkgconfig
        sys-devel/gettext"
 
+src_prepare() {
+       epatch "${FILESDIR}"/${P}-underlinking.patch
+       eautoreconf
+}
+
 src_install() {
        emake DESTDIR="${D}" install || die "emake install failed."
        dodoc AUTHORS ChangeLog NEWS README SKIN-SPECS TODO
Comment 6 Ted Tanberry 2014-01-29 12:54:00 UTC
Created attachment 369052 [details, diff]
gqradio-1.9.2-underlinking.patch
Comment 7 Geoff Madden 2014-01-30 10:11:10 UTC
(In reply to Ted Tanberry from comment #6)
> Created attachment 369052 [details, diff] [details, diff]
> gqradio-1.9.2-underlinking.patch

Thanks for your time Ted,both patches worked to get a completed compile.
Now all I have todo is figure out /dev/radio.
Geoff
Comment 8 Samuli Suominen (RETIRED) gentoo-dev 2014-02-02 09:37:18 UTC
in portage. thanks for reporting, patch, etc.