Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 49210 - app-text/tree-1.4 fails to compile with gcc 3.4
Summary: app-text/tree-1.4 fails to compile with gcc 3.4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mr. Bones. (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 48528
  Show dependency tree
 
Reported: 2004-04-27 14:34 UTC by Mikko Tiihonen
Modified: 2004-04-27 22:38 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Removes the offending function completely because it is never called. (tree-gcc-3.4.diff,433 bytes, patch)
2004-04-27 14:35 UTC, Mikko Tiihonen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikko Tiihonen 2004-04-27 14:34:35 UTC
gcc -march=k8 -pipe -O2 -fomit-frame-pointer -frename-registers -fweb --param max-delay-slot-insn-search=300 --param max-delay-slot-live-search=1000 --param max-pending-list-length=100 --param max-gcse-passes=4 --param max-gcse-memory=104857600 --param max-crossjump-edges=400 -DLINUX_BIGFILE    -c -o tree.o tree.c
tree.c: In function `url_encode':
tree.c:1086: error: label at end of compound statement


Reproducible: Always
Steps to Reproduce:
Comment 1 Mikko Tiihonen 2004-04-27 14:35:42 UTC
Created attachment 30186 [details, diff]
Removes the offending function completely because it is never called.
Comment 2 Robert Moss (RETIRED) gentoo-dev 2004-04-27 16:41:58 UTC
The other solution, of course, is just to change the line:

default:

to instead read:

default:;

If this function is to be used in the future it would be as well to do this instead. If it's leftover cruft then get rid of it. But I'm always dubious about getting rid of functions completely.
Comment 3 Mr. Bones. (RETIRED) gentoo-dev 2004-04-27 16:55:27 UTC
went with just adding the semi.  Thanks for the bug report.