Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 49183 - hdup-1.6.30 (new version)
Summary: hdup-1.6.30 (new version)
Status: RESOLVED DUPLICATE of bug 51986
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High major (vote)
Assignee: Martin Holzer (RETIRED)
URL: http://miek.nl/projects/hdup16/hdup16...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-27 11:18 UTC by Adam Piątyszek
Modified: 2005-07-17 13:06 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
A patch for hdup-1.6.29, which soves the problem of hdup.conf file location (hdup-1.6.29-gentoo.patch,7.36 KB, patch)
2004-04-30 03:23 UTC, Adam Piątyszek
Details | Diff
hdup-1.6.30.ebuild (version update) (hdup-1.6.30.ebuild,1.07 KB, text/plain)
2004-05-02 12:20 UTC, Adam Piątyszek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Piątyszek 2004-04-27 11:18:05 UTC
Hi!

In the latest version of the hdup program, the location of the hdup.conf file has been changed. The author changed the ETCFILE define in src/hdup.h.in to something like @prefix@/etc/hdup/hdup.conf, which causes that in gentoo installation the program looks for the hdup.conf in /usr/etc/hdup dir and of course doesn't find it there.

I reported this problem to the author and I hope it will solve it in the nearest feature... Here is the report I have sent:

#v+
Hello Miek,

I have been using your great program for perfoming backups for some
time. Recently, it has been added to the portage three of the Gentoo
Linux distribution (I had helped a bit in that process).
However, there is a problem with config file location in the latest
bugfix release, which is described in the ChangLog as:

"bugfix: location of hdup.conf in hdup.h.in now has @prefix@ as prefix
 (Thanks to Uli Bubenheimer for reporting). Also make hdup.1 reflect the
 correct location"

This change causes that when one choose the default prefix to
/usr for example (as it is defined in Gentoo's hdup-1.6.29.ebuild) the
location of hdup.conf is somehow strange: /usr/etc/hdup/hdup.conf,
instead of assumed /etc/hdup/hdup.conf.
The Gentoo's hdup-1.6.29.ebuild uses such a form of invoking 'make
install' command:

"make prefix=${D}/usr mandir=${D}/usr/share/man sysconfdir=${D}/etc \
                install || die"
where, ${D} is a temporary directory, which is finally changed into
root directory "/". But the 'sysconfdir' can not be used in that way,
since there is a hard statement in your src/hdup.h.in source file.

To solve this problem I suggest using the sysconfdir parameter in your
configure script, which could be set to ${prefix}/etc as default. But it
requires some changes in src/hdup.h.in (here is the patch):

--- src/hdup.h.in.orig  2004-04-27 19:31:05.779891904 +0200
+++ src/hdup.h.in       2004-04-27 19:31:36.414234776 +0200
@@ -23,7 +23,7 @@
 #define LZOP_PROG      "@lzop@"                                                
 #define SPLIT_PROG      "@split@"                                              
 #define UNSPLIT_PROG    "@cat@"                                                
-#define ETCFILE         "@prefix@/etc/hdup/hdup.conf"
+#define ETCFILE         "@sysconfdir@/hdup/hdup.conf"
 #define REMOTE_HDUP     "/usr/local/bin/hdup"                                  
 #define REMOTE_HDUP_OPT ""      /* default is empty */                         
 #define FILELIST        "/filelist"                                            

and also in the configure script, which I haven't changes, because it is
generated by autoconf. So I left this correction as your homework.

I hope you correct this inconvenience in the forseeable future ;)

Best wishes and keep coding,

ediap
#v-
Comment 1 Martin Holzer (RETIRED) gentoo-dev 2004-04-28 09:59:44 UTC
great guy, thx
Comment 2 Adam Piątyszek 2004-04-30 03:21:44 UTC
The pach I prepared is not the only needed. The author contacted me and send a patchset, which is a bit vague, however it solves the problem.
This patch set is attached below...
Comment 3 Adam Piątyszek 2004-04-30 03:23:10 UTC
Created attachment 30382 [details, diff]
A patch for hdup-1.6.29, which soves the problem of hdup.conf file location
Comment 4 Adam Piątyszek 2004-05-02 12:19:27 UTC
Please find below the hdup-1.6.30.ebuild (new version). The TODO file has been removed from sources, so I removed it from ebuild install part. The previous patch is now redundant, so forget about it ;)
Comment 5 Adam Piątyszek 2004-05-02 12:20:32 UTC
Created attachment 30546 [details]
hdup-1.6.30.ebuild (version update)
Comment 6 Martin Holzer (RETIRED) gentoo-dev 2004-05-03 12:57:31 UTC
in cvs
Comment 7 Adam Piątyszek 2004-05-03 13:38:05 UTC
Thanks for updating, however... bad news again.

There is a problem with using hdup-1.6.30 with bzip2 compression in Gentoo. 
The configure script, which is generated with autoconf from configure.ac can not 
find the correct location of the bzip2 program in Gentoo. This bug could be
easily solved by changing the following line in configure.ac:
AC_PATH_PROG(bzip, bzip, "/usr/bin/bzip2") 
with:
AC_PATH_PROG(bzip, bzip2, "/usr/bin/bzip2")

I reported this problem to the author, so it might be a chance that in the
nearest future there will be another update :-)
Comment 8 Adam Piątyszek 2004-05-25 02:52:46 UTC

*** This bug has been marked as a duplicate of 51986 ***