Upstream has released a new version of the patch. Please update.
which/what upstream? Can't find anything.
I thought you were using those patches http://www.lunar-linux.org/mutt-sidebar/ And the latest version supports "shortpath_indent" which our patches don't, which let me think we are lacking behind.
Adding here that the current Gentoo's sidebar patch is horribly broken with mutt-1.5.22-r1 (currently ~arch) (colors and slowness)
Using 20130219 as base is not so easy. Next, it breaks the sidebar in no longer showing folders (but just full paths) for IMAP stores, so not necessarily an improvement perse. I applied the latest patch on top of 1.5.22: http://prefix.gentooexperimental.org/hg/mutt-patches/file/37ae1797f74e/sidebar-20130219.patch Debian recently did the same: https://bitbucket.org/evgeni/mutt-sidebar/commits/branch/mutt-1-5-22-rel-sidebar
The brokeness of mutt +sidebar is fixed ! Thanks a lot for your work on this. Every one knows it's a pity to maintain so many patches stacked for such a long time. side note: is there tickets in the upstream mutt bug tracking system for each of these patches ?) I found that auto-ordering was confusing and disabled that with set sidebar_sort=no, but why is it the default ? I also found that moving among sidebar entries quickly (eg: scrolling) is slower (while more "regular"), and approximately the same amount of traffic is sent over. Wasn't that the point of Julius' patch 0009 ? (could be very useful !) According to http://blog.plenz.com/2012-01/mutt-sidebar-patch-improvements.html, patches 5 to 20 have been integrated in the sidebar patch 2012 (http://www.lunar-linux.org/mutt-sidebar/) and the last version (2013) should include the shortpath option. Unless I'm mistaken, I use sidebar.patch from mutt-1.5.22-gentoo-patches-r2.tar.bz2 (since for mutt 1.5.22-r3 PATCHSET_REV = -r2).
> it's a pity to [*have to*] maintain so many patches
we're still using our patched version, not the latest one, so the realpath optimisation and more (all of the plenz patches) are not in there. I'm hoping for the Debian initiative (they're late at the party, but try to get it right with maintainers and coordination) to be giving us a good working patch that'll work on 1.5.23 (we don't have it yet, its main reason for release was a security fix that we have backported in 1.5.22-r3).
referencing here since I can't reopen there and that could be a concern about multiples patches: bug #82265
i really just want the new $sidebar_format setting :/
"April 12, 2014 Updated patch for pristine mutt-1.5.23 source package." sounds hopeful, I'll try and look into it tonight
Please give mutt-1.5.23-r3 a try.
(In reply to Fabian Groffen from comment #11) > Please give mutt-1.5.23-r3 a try. Hm, the sidebar now includes the full paths instead of just the basename. I don't think that was intended, wasn't it?
(In reply to Christian Ruppert (idl0r) from comment #12) they added more config options you'll need to set. see the muttrc page as it covers them all.
(In reply to Christian Ruppert (idl0r) from comment #12) > (In reply to Fabian Groffen from comment #11) > > Please give mutt-1.5.23-r3 a try. > > Hm, the sidebar now includes the full paths instead of just the basename. I > don't think that was intended, wasn't it? my dotseppath patch no longer applied, which most likely is the cause
(In reply to Fabian Groffen from comment #14) > (In reply to Christian Ruppert (idl0r) from comment #12) > > (In reply to Fabian Groffen from comment #11) > > > Please give mutt-1.5.23-r3 a try. > > > > Hm, the sidebar now includes the full paths instead of just the basename. I > > don't think that was intended, wasn't it? > > my dotseppath patch no longer applied, which most likely is the cause Thanks, got it! set sidebar_shortpath=yes set sidebar_folderindent=yes
(In reply to Christian Ruppert (idl0r) from comment #15) > (In reply to Fabian Groffen from comment #14) > > (In reply to Christian Ruppert (idl0r) from comment #12) > > > (In reply to Fabian Groffen from comment #11) > > > > Please give mutt-1.5.23-r3 a try. > > > > > > Hm, the sidebar now includes the full paths instead of just the basename. I > > > don't think that was intended, wasn't it? > > > > my dotseppath patch no longer applied, which most likely is the cause > > Thanks, got it! > > set sidebar_shortpath=yes > set sidebar_folderindent=yes /me confused so you're happy now?
(In reply to Fabian Groffen from comment #16) i use this locally: --- a/sidebar.c +++ b/sidebar.c @@ -320,11 +321,7 @@ int draw_sidebar(int menu) { } if (sidebar_folder_depth > 0) { if (option(OPTSIDEBARSHORTPATH)) { - tmp_folder_name = strrchr(tmp->path, '.'); - if (tmp_folder_name == NULL) - tmp_folder_name = mutt_basename(tmp->path); - else - tmp_folder_name++; + tmp_folder_name = mutt_basename(tmp->path); } else tmp_folder_name = tmp->path + strlen(Maildir) + 1;
dotseppath readded in mutt-1.5.23-r4
With mutt-1.5.23-r4 (Haven't tried r3, but r2 was working correctly), the first char of my mailboxes are all eaten away. The relevant parts of my muttrc: set sidebar_width=32 set sidebar_visible=yes set sidebar_delim='|'
