Created attachment 363390 [details, diff] Patch to fix wireshark compile against gtk+-3.10.x For background please see: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9340 https://github.com/Heather/gentoo-gnome/issues/84 gtk+-3.10.x breaks the wireshark build due to wireshark using deprecated symbols and yet having -DGTK_DISABLE_DEPRECATED defined during the build. Few possible solutions: * net-analyzer/wireshark ebuilds block >=x11-libs/gtk+-3.10 until wireshark upstream has the fix or * I've created a patch to remove the DISABLE_DEPRECATED definitions from the wireshark build. I've tested that the build succeeds against gtk+-3.10.x with this patch. I'm attaching the patch to this bug.
gtk+ 3.10 isn't even in the tree yet.
Well I understand that it's hard to test and check how it goes there but when I set 3.10 tracker bug to be this bug blocker it shows me "RESOLVED" so I'm not sure if RESOLVED is correct status here.
ebuild shouldn't use DEPRECATED flags anyway
(In reply to Pacho Ramos from comment #3) > ebuild shouldn't use DEPRECATED flags anyway Please file a new bug report about that.
Where? Upstream side? DISABLE_DEPRECATED flags also need to be dropped downstream like done in many other ebuilds currently
Also, the usage of DEPRECATED symbols problem is already mentioned in both bugs (this one and upstream one) :/
(In reply to Pacho Ramos from comment #6) > Also, the usage of DEPRECATED symbols problem is already mentioned in both > bugs (this one and upstream one) :/ This bug report is about a compile failure. The one you're looking for seems to be about USE flags.
(In reply to Jeroen Roovers from comment #7) [...] > This bug report is about a compile failure. The one you're looking for seems > to be about USE flags. I guess we are thinking on a different problem, I mean that build system is passing DISABLE_DEPRECATED flags and, then, failing to build. You can even use a gnome2-utils.eclass function for that: gnome2_disable_deprecation_warning. But it's not related with USE flags. I can also use that one and do the job myself if you are prefer due being busy or so :) Thanks a lot
(In reply to Pacho Ramos from comment #8) > I guess we are thinking on a different problem, I mean that build system is > passing DISABLE_DEPRECATED flags and, then, failing to build. You can even > use a gnome2-utils.eclass function for that: > gnome2_disable_deprecation_warning. But it's not related with USE flags. OK. > I can also use that one and do the job myself if you are prefer due being > busy or so :) What would that look like?
You would need to add: gnome2_disable_deprecation_warning to src_prepare, and inherit gnome2-utils.eclass
So this should do it? Index: wireshark-1.11.2.ebuild =================================================================== RCS file: /var/cvsroot/gentoo-x86/net-analyzer/wireshark/wireshark-1.11.2.ebuild,v retrieving revision 1.1 diff -u -B -r1.1 wireshark-1.11.2.ebuild --- wireshark-1.11.2.ebuild 19 Nov 2013 02:30:54 -0000 1.1 +++ wireshark-1.11.2.ebuild 19 Nov 2013 22:26:07 -0000 @@ -3,7 +3,7 @@ # $Header: /var/cvsroot/gentoo-x86/net-analyzer/wireshark/wireshark-1.11.2.ebuild,v 1.1 2013/11/19 02:30:54 jer Exp $ EAPI=5 -inherit autotools eutils fcaps user +inherit autotools eutils fcaps gnome2-utils user [[ -n ${PV#*_rc} && ${PV#*_rc} != ${PV} ]] && MY_P=${PN}-${PV/_} || MY_P=${P} DESCRIPTION="A network protocol analyzer formerly known as ethereal" @@ -90,6 +90,8 @@ epatch_user + gnome2_disable_deprecation_warning + eautoreconf }
I have just tried it and the call should be after eautoreconf, this is caused by eclass function changing configure but not configure.ac as, touching both, sometimes triggers maintainer-mode
(In reply to Pacho Ramos from comment #12) > I have just tried it and the call should be after eautoreconf, this is > caused by eclass function changing configure but not configure.ac as, > touching both, sometimes triggers maintainer-mode How could we possibly trigger maintainer mode when we do eautoreconf /after/ patching?
What you probably meant was that your ./configure changes would be lost (and the eclass comments aren't properly explaining that).
Also, configure.ac appends the necessary bits to CPPFLAGS already, only adds -DGSEAL_ENABLE for gtk+-2, so we should probably fix that instead. Could someone at least post a proper build log here?
Created attachment 363796 [details, diff] wireshark-1.11.2-gtk-deprecated-warnings.patch Please test.
(In reply to Jeroen Roovers from comment #16) > Created attachment 363796 [details, diff] [details, diff] > wireshark-1.11.2-gtk-deprecated-warnings.patch > > Please test. Or does this do the inverse of what you want?
You can also simply run sed for dropping the *DEPRECATED* flags from configure.ac :/
*wireshark-1.10.4 (18 Dec 2013) *wireshark-1.8.12 (18 Dec 2013) 18 Dec 2013; Jeroen Roovers <jer@gentoo.org> +wireshark-1.8.12.ebuild, +wireshark-1.10.4.ebuild, +files/wireshark-1.8.12-gtk-deprecated-warnings.patch, +files/wireshark-1.10.4-gtk-deprecated-warnings.patch: Version bump (bug #494612). ... 11 Dec 2013; Jeroen Roovers <jer@gentoo.org> wireshark-1.11.2.ebuild, +files/wireshark-1.11.2-gtk-deprecated-warnings.patch: Possibly fix compile problems with x11-libs/gtk+3.10* (bug #491464). A patch has gone into the tree with the above versions. The patches do quite a bit more than a sed script could, I think. Has anyone cared to test these yet?
Just tested and it's fixed, thanks!