Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 491464 - net-analyzer/wireshark compilation fails against x11-libs/gtk+-3.10* due to usage of deprecated symbols
Summary: net-analyzer/wireshark compilation fails against x11-libs/gtk+-3.10* due to u...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Netmon project
URL: https://bugs.wireshark.org/bugzilla/s...
Whiteboard:
Keywords:
Depends on:
Blocks: gnome-3.10
  Show dependency tree
 
Reported: 2013-11-17 07:23 UTC by Mark R. Pariente
Modified: 2014-02-08 22:29 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to fix wireshark compile against gtk+-3.10.x (wireshark-gtk+-3.10-compile.diff,1.17 KB, patch)
2013-11-17 07:23 UTC, Mark R. Pariente
Details | Diff
wireshark-1.11.2-gtk-deprecated-warnings.patch (wireshark-1.11.2-gtk-deprecated-warnings.patch,545 bytes, patch)
2013-11-22 14:52 UTC, Jeroen Roovers (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark R. Pariente 2013-11-17 07:23:33 UTC
Created attachment 363390 [details, diff]
Patch to fix wireshark compile against gtk+-3.10.x

For background please see:

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9340
https://github.com/Heather/gentoo-gnome/issues/84

gtk+-3.10.x breaks the wireshark build due to wireshark using deprecated symbols and yet having -DGTK_DISABLE_DEPRECATED defined during the build.

Few possible solutions:

* net-analyzer/wireshark ebuilds block >=x11-libs/gtk+-3.10 until wireshark upstream has the fix

or

* I've created a patch to remove the DISABLE_DEPRECATED definitions from the wireshark build. I've tested that the build succeeds against gtk+-3.10.x with this patch. I'm attaching the patch to this bug.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2013-11-17 15:15:13 UTC
gtk+ 3.10 isn't even in the tree yet.
Comment 2 Cynede (RETIRED) gentoo-dev 2013-11-18 04:13:22 UTC
Well I understand that it's hard to test and check how it goes there but when I set 3.10 tracker bug to be this bug blocker it shows me "RESOLVED" so I'm not sure if RESOLVED is correct status here.
Comment 3 Pacho Ramos gentoo-dev 2013-11-18 20:09:15 UTC
ebuild shouldn't use DEPRECATED flags anyway
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2013-11-18 23:02:23 UTC
(In reply to Pacho Ramos from comment #3)
> ebuild shouldn't use DEPRECATED flags anyway

Please file a new bug report about that.
Comment 5 Pacho Ramos gentoo-dev 2013-11-19 07:08:12 UTC
Where? Upstream side? DISABLE_DEPRECATED flags also need to be dropped downstream like done in many other ebuilds currently
Comment 6 Pacho Ramos gentoo-dev 2013-11-19 07:16:24 UTC
Also, the usage of DEPRECATED symbols problem is already mentioned in both bugs (this one and upstream one) :/
Comment 7 Jeroen Roovers (RETIRED) gentoo-dev 2013-11-19 15:19:11 UTC
(In reply to Pacho Ramos from comment #6)
> Also, the usage of DEPRECATED symbols problem is already mentioned in both
> bugs (this one and upstream one) :/

This bug report is about a compile failure. The one you're looking for seems to be about USE flags.
Comment 8 Pacho Ramos gentoo-dev 2013-11-19 20:11:46 UTC
(In reply to Jeroen Roovers from comment #7)
[...]
> This bug report is about a compile failure. The one you're looking for seems
> to be about USE flags.

I guess we are thinking on a different problem, I mean that build system is passing DISABLE_DEPRECATED flags and, then, failing to build. You can even use a gnome2-utils.eclass function for that: gnome2_disable_deprecation_warning. But it's not related with USE flags.

I can also use that one and do the job myself if you are prefer due being busy or so :)

Thanks a lot
Comment 9 Jeroen Roovers (RETIRED) gentoo-dev 2013-11-19 20:28:56 UTC
(In reply to Pacho Ramos from comment #8)
> I guess we are thinking on a different problem, I mean that build system is
> passing DISABLE_DEPRECATED flags and, then, failing to build. You can even
> use a gnome2-utils.eclass function for that:
> gnome2_disable_deprecation_warning. But it's not related with USE flags.

OK.

> I can also use that one and do the job myself if you are prefer due being
> busy or so :)

What would that look like?
Comment 10 Pacho Ramos gentoo-dev 2013-11-19 21:05:47 UTC
You would need to add:
gnome2_disable_deprecation_warning

to src_prepare, and inherit gnome2-utils.eclass
Comment 11 Jeroen Roovers (RETIRED) gentoo-dev 2013-11-19 22:26:41 UTC
So this should do it?

Index: wireshark-1.11.2.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/net-analyzer/wireshark/wireshark-1.11.2.ebuild,v
retrieving revision 1.1
diff -u -B -r1.1 wireshark-1.11.2.ebuild
--- wireshark-1.11.2.ebuild     19 Nov 2013 02:30:54 -0000      1.1
+++ wireshark-1.11.2.ebuild     19 Nov 2013 22:26:07 -0000
@@ -3,7 +3,7 @@
 # $Header: /var/cvsroot/gentoo-x86/net-analyzer/wireshark/wireshark-1.11.2.ebuild,v 1.1 2013/11/19 02:30:54 jer Exp $
 
 EAPI=5
-inherit autotools eutils fcaps user
+inherit autotools eutils fcaps gnome2-utils user
 
 [[ -n ${PV#*_rc} && ${PV#*_rc} != ${PV} ]] && MY_P=${PN}-${PV/_} || MY_P=${P}
 DESCRIPTION="A network protocol analyzer formerly known as ethereal"
@@ -90,6 +90,8 @@
 
        epatch_user
 
+       gnome2_disable_deprecation_warning
+
        eautoreconf
 }
Comment 12 Pacho Ramos gentoo-dev 2013-11-20 07:08:35 UTC
I have just tried it and the call should be after eautoreconf, this is caused by eclass function changing configure but not configure.ac as, touching both, sometimes triggers maintainer-mode
Comment 13 Jeroen Roovers (RETIRED) gentoo-dev 2013-11-22 14:16:34 UTC
(In reply to Pacho Ramos from comment #12)
> I have just tried it and the call should be after eautoreconf, this is
> caused by eclass function changing configure but not configure.ac as,
> touching both, sometimes triggers maintainer-mode

How could we possibly trigger maintainer mode when we do eautoreconf /after/ patching?
Comment 14 Jeroen Roovers (RETIRED) gentoo-dev 2013-11-22 14:23:53 UTC
What you probably meant was that your ./configure changes would be lost (and the eclass comments aren't properly explaining that).
Comment 15 Jeroen Roovers (RETIRED) gentoo-dev 2013-11-22 14:47:56 UTC
Also, configure.ac appends the necessary bits to CPPFLAGS already, only adds -DGSEAL_ENABLE for gtk+-2, so we should probably fix that instead. Could someone at least post a proper build log here?
Comment 16 Jeroen Roovers (RETIRED) gentoo-dev 2013-11-22 14:52:57 UTC
Created attachment 363796 [details, diff]
wireshark-1.11.2-gtk-deprecated-warnings.patch

Please test.
Comment 17 Jeroen Roovers (RETIRED) gentoo-dev 2013-11-22 15:01:21 UTC
(In reply to Jeroen Roovers from comment #16)
> Created attachment 363796 [details, diff] [details, diff]
> wireshark-1.11.2-gtk-deprecated-warnings.patch
> 
> Please test.

Or does this do the inverse of what you want?
Comment 18 Pacho Ramos gentoo-dev 2013-12-24 13:01:21 UTC
You can also simply run sed for dropping the *DEPRECATED* flags from configure.ac :/
Comment 19 Jeroen Roovers (RETIRED) gentoo-dev 2013-12-24 17:07:20 UTC
*wireshark-1.10.4 (18 Dec 2013)
*wireshark-1.8.12 (18 Dec 2013)
  18 Dec 2013; Jeroen Roovers <jer@gentoo.org> +wireshark-1.8.12.ebuild,
  +wireshark-1.10.4.ebuild,
  +files/wireshark-1.8.12-gtk-deprecated-warnings.patch,
  +files/wireshark-1.10.4-gtk-deprecated-warnings.patch:
  Version bump (bug #494612).

  ...

  11 Dec 2013; Jeroen Roovers <jer@gentoo.org> wireshark-1.11.2.ebuild,
  +files/wireshark-1.11.2-gtk-deprecated-warnings.patch:
  Possibly fix compile problems with x11-libs/gtk+3.10* (bug #491464).


A patch has gone into the tree with the above versions. The patches do quite a bit more than a sed script could, I think. Has anyone cared to test these yet?
Comment 20 Pacho Ramos gentoo-dev 2014-02-08 22:29:49 UTC
Just tested and it's fixed, thanks!