Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 490502 - sys-apps/lm_sensors: sensord ignores configuration files below /etc/sensors.d
Summary: sys-apps/lm_sensors: sensord ignores configuration files below /etc/sensors.d
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Thomas Deutschmann
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-05 20:24 UTC by Timo Eissler
Modified: 2016-09-16 12:43 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Timo Eissler 2013-11-05 20:24:16 UTC
sensord ignores all other configuration files if there is one specified via the command line with "-c".

So if someone configures his sensors within configuration files below /etc/sensors.d/ these files will be ignored because the init script of sensord (/etc/init.d/sensord) always starts sensord with "--config-file /etc/sensors3.conf".

Please remove the "--config-file ${CONFIG}" part from the init script.
If no configuration file is specified sensord will read his default config /etc/sensors3.conf and all files below /etc/sensors.d like expected.
Comment 1 Thomas Deutschmann gentoo-dev Security 2016-08-09 13:57:36 UTC
Well, we will drop the explicit "--config-file" usage in the upcoming bump.

However it looks like you are not 100% correct: If you want make use of "/etc/sensors.d" you have to make sure that neither "/etc/sensors3.conf" nor "/sensors.conf" exists, see https://github.com/groeck/lm-sensors/blob/eb5cf8b2ec95685fd50059e36d569ed1a3378b11/lib/init.c#L190-L217:

If no CFG argument was set it tries to read DEFAULT_CONFIG_FILE or ALT_CONFIG_FILE. If successful it will jump to "exit_cleanup" so "add_config_from_dir" in line 214 will be skipped like when a CFG argument was set.
Comment 2 Thomas Deutschmann gentoo-dev Security 2016-09-16 12:43:22 UTC
Now in tree, thanks for the report!

> commit 9ba6c0d353dd2ad3936fe35095588648b472f188
> Author: Thomas Deutschmann
> Date:   Fri Sep 16 14:36:11 2016 +0200
> 
>     sys-apps/lm_sensors: Version bump to snapshot release from 2016-07-25; Package now uses module-load service
> 
>     Changes:
>     ========
>      - Based on latest unreleased changes (snapshot release from 2016-07-25;
>        updated/added detection for Fintek F81768, Nuvoton NCT6793D, Microchip
>        MCP9808 and Mark F71868A chips; various fixes for sensors-detect, see
>        https://git.io/v6Wig for all changes)
> 
>      - sensors-detect now writes to "/etc/modules-load.d/lm_sensors.conf" and
>        uses a config file protection mechanism like known from emerge (i.e.
>        after making changes you have to call tools such as dispatch-conf,
>        cfg-update or etc-update to merge the changes;
>        new "--no-gentoo-config-protect" parameter will disable config file
>        protection)
> 
>      - Due to previous change lm_service service no longer loads modules. You
>        have to use mechanism your init system provides to do that (i.e. make
>        sure your init system's modules-load service is enabled).
> 
>      - Ebuild is now multilib compatible (see bug 529684)
> 
>      - Runscripts no longer passes config file as argument. While this removes
>        the possibility to use different configurations per default services it
>        allows you to use "/etc/sensors.d" (see bug 490502 and bug 307249)
> 
>      - Runscripts improved in general. I.e. if you start fancontrol service
>        without a valid config (so that fancontrol doesn't start and exit with
>        an error) you will now know at least, that the service didn't start.
>        Now you will also have reliable status functions to know service state.
> 
>     Gentoo-Bug: https://bugs.gentoo.org/592916
>     Gentoo-Bug: https://bugs.gentoo.org/529684
>     Gentoo-Bug: https://bugs.gentoo.org/490502
>     Gentoo-Bug: https://bugs.gentoo.org/307249
> 
>     Package-Manager: portage-2.3.0