Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 489812 - dev-perl/CHI-0.580 with dev-perl/MooX-Types-MooseLike-0.250.0 - MooX::Types::MooseLike::Numeric got split off
Summary: dev-perl/CHI-0.580 with dev-perl/MooX-Types-MooseLike-0.250.0 - MooX::Types::...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Perl team
URL:
Whiteboard:
Keywords:
Depends on: 495140 495154
Blocks:
  Show dependency tree
 
Reported: 2013-10-29 19:29 UTC by Kent Fredric (IRC: kent\n) (RETIRED)
Modified: 2016-08-08 03:31 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
CHI-0.580.0-r1.ebuild (CHI-0.580.0-r1.ebuild,1007 bytes, text/plain)
2013-12-24 13:14 UTC, Kent Fredric (IRC: kent\n) (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2013-10-29 19:29:46 UTC
When @patrick bumped Moo dev-perl/MooX-Types-MooseLike-0.250.0, He didn't appear to notice that it stopped shipping 2 modules.

https://metacpan.org/diff/release/MATEU/MooX-Types-MooseLike-0.21/MATEU/MooX-Types-MooseLike-0.25

dev-perl/CHI depends on MooX::Types::MooseLike::Numeric, which was split out in 0.220.0, and there are no corresponding packages in tree for this.

Additionally, dev-perl/CHI only "test depends" on MooX-Types, meaning dev-perl/CHI is broken on ~ for anyone who doesn't use FEATURES=test

Really, don't add deps as test-only unless you *know* they're testing deps.
Comment 1 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2013-12-24 13:14:21 UTC
Created attachment 366098 [details]
CHI-0.580.0-r1.ebuild

-r1 bump required, because everyone who previously installed CHI _will_ have a broken CHI, due to the combination of 

- Having a runtime dependency listed as a testing dependency
- Having tests disabled with RESTRICT=test

It may not be an issue for people who manually solved this dependency problem, but that seems unlikley due to bug 495140

Additionally, I discovered 2 other upstream dependencies ommitted:

- Task::Weaken  # Although not critical, it causes noise if not installed during src_configure

- Moo 1.3.0  #  The ebuild declares simply "dev-perl/Moo" instead of a specific version, where upstream declare a specific version.

As upstreams policy is basically "no support at all" if the dependencies listed are not met, and that toolchains should _die_ if upstream dependencies are not met, and that the toolchains should only ignore unsatisfied dependencies at _users_ request,  its better for us to follow upstreams recommendation.

( Incidentally, the tests do pass with Moo 1.0.3  )

Also, I considered using a "|| (  )" dep, but its useless here, because upstream declares " >= MooX-Types-MooseLike-0.230.0 ", and the || ( ) dep would be :

   || ( <MooX-Types-MooseLike-0.230.0 MooX-Types-MooseLike-Numeric )

Which would only be something applicable to other versions of CHI.. but other versions of CHI in tree don't even use Moo, so its a non-problem.

None of the other packages in tree in dev-perl/ using ::MooseLike are using ::Numeric.


Ebuild Diff: 

--- CHI-0.580.0.ebuild  2013-12-25 01:51:58.876119228 +1300
+++ CHI-0.580.0-r1.ebuild       2013-12-25 01:58:47.824217247 +1300
@@ -14,23 +14,24 @@
 KEYWORDS="~amd64 ~x86"
 IUSE="test"
 
-RESTRICT="test" # missing some packages for that
-
 RDEPEND="
        dev-perl/Hash-MoreUtils
        >=dev-perl/Carp-Assert-0.200.0
        dev-perl/String-RewritePrefix
        >=dev-perl/Log-Any-0.140.0
        >=dev-perl/List-MoreUtils-0.330.0
-       dev-perl/Moo
+       >=dev-perl/Moo-1.3.0
        dev-perl/Moose
        >=dev-perl/Try-Tiny-0.110.0
        >=dev-perl/Time-Duration-Parse-0.60.0
        >=dev-perl/Time-Duration-1.60.0
+       dev-perl/Task-Weaken
        dev-perl/Data-UUID
        dev-perl/Digest-JHash
        dev-perl/TimeDate
        dev-perl/JSON
+       >=dev-perl/MooX-Types-MooseLike-0.230.0
+       dev-perl/MooX-Types-MooseLike-Numeric
 "
 
 DEPEND="${RDEPEND}
@@ -39,7 +40,6 @@
                dev-perl/Test-Exception
                dev-perl/Test-Class
                dev-perl/Test-Warn
-               dev-perl/MooX-Types-MooseLike
        )"
 
-SRC_TEST="do"
+SRC_TEST="do parallel"
Comment 2 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2016-08-08 03:31:34 UTC
Anniversary of this bug being fixed next week:

commit c2d386f511265417225002d363a400a060cf7a73
Author: Andreas Hüttel <dilfridge@gentoo.org>
Date:   Tue Jul 21 22:22:06 2015 +0000

    Version bump
    
    Package-Manager: portage-2.2.20/cvs/Linux x86_64
    Manifest-Sign-Key: 0x0B08240A96F66571

 dev-perl/CHI/CHI-0.560.0.ebuild | 41 -----------------------------------------
 dev-perl/CHI/CHI-0.580.0.ebuild | 45 ---------------------------------------------
 dev-perl/CHI/CHI-0.600.0.ebuild | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
 dev-perl/CHI/ChangeLog          |  8 +++++++-
 dev-perl/CHI/Manifest           | 36 +++++++++++++++++-------------------