Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 489666 - app-text/dictd: systemd service file submission
Summary: app-text/dictd: systemd service file submission
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Spell checking utilities and dictionaries -- related bugs (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: install-systemd-unit
  Show dependency tree
 
Reported: 2013-10-28 16:23 UTC by Juan
Modified: 2013-11-12 20:20 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
proposed service file for dictd on systemd (dictd.service,170 bytes, text/plain)
2013-10-28 16:26 UTC, Juan
Details
dictd.service (dictd.service,181 bytes, text/plain)
2013-10-28 19:20 UTC, Pacho Ramos
Details
new dictd service file (dictd.service,268 bytes, text/plain)
2013-10-31 12:21 UTC, Juan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Juan 2013-10-28 16:23:38 UTC
app-text/dictd does not have a service file for systemd

Reproducible: Always

Steps to Reproduce:
1. Install dictd
2.
3.
Actual Results:  
There is not service file to start the server
Comment 1 Juan 2013-10-28 16:26:36 UTC
Created attachment 362146 [details]
proposed service file for dictd on systemd

I have not previous experience creating service files for systemd but it seems to work well in my system
Comment 2 Pacho Ramos gentoo-dev 2013-10-28 19:19:47 UTC
I cannot even start dictd (1.12.1) :S
# /usr/sbin/dictd 
/etc/dict/dictd.conf:22: syntax error, unexpected $end
/etc/dict/dictd.conf:22: #LASTLINE
/etc/dict/dictd.conf:22:          ^
dictd (yyerror): parse error
parse error
Comment 3 Pacho Ramos gentoo-dev 2013-10-28 19:20:17 UTC
Created attachment 362160 [details]
dictd.service
Comment 4 Alexander Tsoy 2013-10-29 13:08:03 UTC
(In reply to Pacho Ramos from comment #2)
> I cannot even start dictd (1.12.1) :S

You need to add at least one dictionary.
Comment 5 Pacho Ramos gentoo-dev 2013-10-29 19:17:12 UTC
I installed app-dicts/dictd-dicts as suggested by ebuild :/
Comment 6 Alexander Tsoy 2013-10-29 20:28:10 UTC
(In reply to Pacho Ramos from comment #5)
> I installed app-dicts/dictd-dicts as suggested by ebuild :/

Init script automatically adds all installed dictionaries to config. Yeah, that's horrible. :)
Comment 7 Pacho Ramos gentoo-dev 2013-10-29 20:48:43 UTC
Bleh :(

Not sure how to deal with it then (I haven't seen any clue on fedora and arch), maybe moving the conf updating to "config()"? Move it to a script we run before start?
Comment 8 Alexander Tsoy 2013-10-30 19:04:34 UTC
(In reply to Pacho Ramos from comment #7)
> Move it to a script we run before start?

IMHO config generation shouldn't be a part of service startup process.
Comment 9 Pacho Ramos gentoo-dev 2013-10-30 19:13:11 UTC
I don't have a strong opinion :/, probably the info pointing people to configure it could be included in ebuild and that would be enough
Comment 10 Juan 2013-10-31 12:21:19 UTC
Created attachment 362350 [details]
new dictd service file

Added restart and read options on the default dictd configuration file (/etc/conf.d/dictd)
Comment 11 Pacho Ramos gentoo-dev 2013-11-11 21:17:15 UTC
(In reply to Pacho Ramos from comment #9)
> I don't have a strong opinion :/, probably the info pointing people to
> configure it could be included in ebuild and that would be enough

Do you know any example about the kind of instructions we should show to tell people how to add dicts to their configs? Thanks
Comment 12 Alexander Tsoy 2013-11-12 17:54:23 UTC
May be install some examples and tell people to read them?

# pwd
/var/tmp/portage/app-text/dictd-1.12.1/work/dictd-1.12.1/examples
# ls -1 dictd*
dictd1.conf
dictd2.conf
dictd3.conf
dictd4.conf
dictd_complex.conf
dictd_mime.conf
dictd_plugin_dbi.conf
dictd_popen.conf.in
dictd_site.txt
dictd_virtual.conf


"dictd1.conf" is the most basic example, and openrc script populates config using the same format.
Comment 13 Pacho Ramos gentoo-dev 2013-11-12 20:20:29 UTC
+*dictd-1.12.1-r1 (12 Nov 2013)
+
+  12 Nov 2013; Pacho Ramos <pacho@gentoo.org> +dictd-1.12.1-r1.ebuild,
+  +files/dictd.service, -dictd-1.11.1-r1.ebuild, -dictd-1.12.0.ebuild,
+  files/1.10.11/dictd.conf:
+  Add unit file (#489666 by Juan and Alexander Tsoy), drop old.
+