Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 489596 - dev-libs/libconfig-1.4.9-r1 USE=examples should not install Makefile.am and Makefile.in
Summary: dev-libs/libconfig-1.4.9-r1 USE=examples should not install Makefile.am and M...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Johan Bergström
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-27 17:35 UTC by Karl Lindén
Modified: 2014-07-02 06:08 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
The build log (build.log,28.72 KB, text/plain)
2013-10-27 17:40 UTC, Karl Lindén
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Lindén 2013-10-27 17:35:21 UTC
When I emerge dev-libs/libconfig-1.4.9-r1[examples] I note that it installs Makefile.am and Makefile.in in the example directories. I don't think that they should be installed because they do not serve any purpose outside the build system.



Reproducible: Always

Steps to Reproduce:
1. emerge -av dev-libs/libconfig
2. equery f dev-libs/libconfig
Actual Results:  
Makefile.am and Makefile.in are installed into the example directories.

Expected Results:  
Makefile.am and Makefile.in should not be installed into the example directories.

Portage 2.2.7 (default/linux/amd64/13.0/desktop, gcc-4.8.1, glibc-2.17, 3.11.6-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-3.11.6-gentoo-x86_64-AMD_Athlon-tm-_II_X4_640_Processor-with-gentoo-2.2
KiB Mem:     8180876 total,   2481744 free
KiB Swap:    2097148 total,   2097148 free
Timestamp of tree: Sun, 27 Oct 2013 10:30:01 +0000
ld GNU ld (GNU Binutils) 2.23.2
distcc 3.1 x86_64-pc-linux-gnu [disabled]
app-shells/bash:          4.2_p45
dev-java/java-config:     2.2.0
dev-lang/python:          2.7.5-r4, 3.3.2-r2
dev-util/cmake:           2.8.12
dev-util/pkgconfig:       0.28
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.12.3
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.11.6, 1.13.4, 1.14
sys-devel/binutils:       2.23.2
sys-devel/gcc:            4.7.3-r1, 4.8.1-r1
sys-devel/gcc-config:     1.8
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.11 (virtual/os-headers)
sys-libs/glibc:           2.17
Repositories: gentoo crossdev proaudio lilrc
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=amdfam10 -O2 -fomit-frame-pointer -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -march=amdfam10 -O2 -fomit-frame-pointer -pipe"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs buildsyspkg config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news noinfo parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://ftp.df.lth.se/pub/gentoo/ rsync://ftp.df.lth.se/pub/gentoo/ http://mirror.mdfnet.se/gentoo"
LANG="sv_SE.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j4"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/crossdev /home/kalle/overlays/proaudio /home/kalle/overlays/lilrc"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow 3dnowext X a52 aac acl amd64 aspell avahi bluetooth cairo caps cd cdda cddb cdr consolekit cracklib cups curl dbus dssi dvd dvdr exif ffmpeg fftw filecaps flac fltk gallium gif gimp git glib gmp gnutls gstreamer gtk gtk2 gtkspell gtkstyle gudev hwdb jack javascript jit joystick jpeg keymap kmod ladspa lame libgig libnotify libsamplerate lv2 mad mmx mmxext mp3 mpeg multilib netifrc nls nptl ogg opengl openmp openrc orc pam pdf png policykit pulseaudio qt4 readline spell sse sse2 sse3 sse4_1 ssl startup-notification subversion svg svn theora threads thunar tiff truetype udev unicode usb v4l vorbis webgl x264 xcb xcomposite xfce xml xorg xscreensaver zlib" ABI_X86="64" ALSA_CARDS="ca0106 hda-intel" CURL_SSL="gnutls" ELIBC="glibc" GRUB_PLATFORMS="pc" INPUT_DEVICES="evdev" KERNEL="linux" LINGUAS="en en_GB sv sv_SE" PYTHON_SINGLE_TARGET="python3_3" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby20" USERLAND="GNU" VIDEO_CARDS="radeon" XFCE_PLUGINS="trash"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON

=================================================================
                        Package Settings
=================================================================

dev-libs/libconfig-1.4.9-r1 was built with the following:
USE="examples -cxx -static-libs" ABI_X86="64 -32 -x32"
Comment 1 Karl Lindén 2013-10-27 17:40:41 UTC
Created attachment 362060 [details]
The build log
Comment 2 Johan Bergström 2013-11-21 23:05:17 UTC
Sounds good to me. I've talked somewhat with upstream re disabling/enabling everything and their general advice is not to. If you disable chert, things start breaking. I still prefer having it there and fixing use cases.

Patch:
--- dev-libs/xapian/xapian-1.3.1-r1.ebuild
+++ dev-libs/xapian/xapian-1.3.1-r1.ebuild
@@ -17,7 +17,7 @@ IUSE="doc static-libs -sse +sse2 +brass +chert +inmemory"

 DEPEND="sys-libs/zlib"
 RDEPEND="${DEPEND}"
-
+REQUIRED_USE="inmemory? ( chert )"
 S="${WORKDIR}/${MY_P}"

 src_configure() {
Comment 3 Johan Bergström 2013-11-21 23:07:12 UTC
Jesus christ. Wrong bug - sorry. Updated patch shortly.
Comment 4 Johan Bergström 2013-11-21 23:25:23 UTC
Proper patch (https://github.com/jbergstroem/gentoo-overlay/compare/master...libconfig-examples):

commit 45dbf446ffa0dffec313ef9f4c1ec39a839c1abb
Author: Johan Bergström <bugs@bergstroem.nu>
Date:   Fri Nov 22 10:20:41 2013 +1100

    Don't install Makefile.*

    Fixes https://bugs.gentoo.org/show_bug.cgi?id=489596

diff --git dev-libs/libconfig/libconfig-1.4.9-r1.ebuild dev-libs/libconfig/libconfig-1.4.9-r1.ebuild
index 5f1aaa6..a373140 100644
--- dev-libs/libconfig/libconfig-1.4.9-r1.ebuild
+++ dev-libs/libconfig/libconfig-1.4.9-r1.ebuild
@@ -49,6 +49,7 @@ src_test() {
 src_install() {
        autotools-multilib_src_install
        if use examples; then
+               find examples/ -name "Makefile.*" -delete || die
                local dir
                for dir in examples/c examples/c++; do
                        insinto /usr/share/doc/${PF}/${dir}
Comment 5 Johan Bergström 2014-07-02 01:48:19 UTC
Ping? Looks trivial enough to get in.
Comment 6 Yixun Lan archtester gentoo-dev 2014-07-02 06:08:51 UTC
+  02 Jul 2014; Yixun Lan <dlan@gentoo.org> libconfig-1.4.9-r1.ebuild:
+  fixed, bug #489596, thanks Johan Bergström