487382 – openrc: /etc/init.d/mount-ro inistscript redundancy

Bug 487382 - openrc: /etc/init.d/mount-ro inistscript redundancy

Summary: openrc: /etc/init.d/mount-ro inistscript redundancy

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	OpenRC Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	481182
	Show dependency tree

Reported:	2013-10-09 06:02 UTC by Patrick Lauer
Modified:	2013-10-18 22:16 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Patrick Lauer gentoo-dev

2013-10-09 06:02:50 UTC

# Flush all pending disk writes now
        sync; sync

This is needless duplication, see for example:

http://utcc.utoronto.ca/~cks/space/blog/unix/TheLegendOfSync

Comment 1 William Hubbs gentoo-dev

2013-10-09 16:18:16 UTC

That example isn't quite clear on whether I should remove all sync
commands or keep one?

Comment 2 Patrick Lauer gentoo-dev

2013-10-10 05:23:15 UTC

Keep one, the second one is redundant.

Comment 3 William Hubbs gentoo-dev

2013-10-18 22:16:00 UTC

I found the same issue in localmount. These are both fixed in commit
d2988dc and will be included in OpenRC-0.13.