Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 487084 - sys-apps/openrc: killprocs init script wastes time on shutdown
Summary: sys-apps/openrc: killprocs init script wastes time on shutdown
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: OpenRC (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: OpenRC Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-06 10:57 UTC by Patrick Lauer
Modified: 2016-05-05 22:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Lauer gentoo-dev 2013-10-06 10:57:41 UTC
To quote from /etc/init.d/killprocs:

start()
{
        ebegin "Terminating remaining processes"
        killall5 -15 ${killall5_opts}
        sleep 1
        eend 0
        ebegin "Killing remaining processes"
        killall5 -9 ${killall5_opts}
        sleep 1
        eend 0
}

This needlessly spends two seconds waiting. I don't see any negative effect from removing the sleep.
Comment 1 Andreas Sturmlechner gentoo-dev 2013-12-28 13:22:55 UTC
This works absolutely fine on my setup and the time savings together with bug 487384 do add up, with the countless reboots my system needs to go through in the hunt for various i915 bugs...
Comment 2 William Hubbs gentoo-dev 2016-05-05 22:18:37 UTC
https://github.com/openrc/openrc/commit/92e2f2c

This will be in OpenRC-0.21.