Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 486074 - git-r3 sets non-sane defaults (EGIT_NONSHALLOW disabled)
Summary: git-r3 sets non-sane defaults (EGIT_NONSHALLOW disabled)
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michał Górny
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-26 12:21 UTC by Julian Ospald
Modified: 2014-02-20 22:38 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Ospald 2013-09-26 12:21:55 UTC
googlecode doesn't seem to support shallow clients at all and we have already one conversion that broke silently

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/dev-python/snakeoil/snakeoil-9999.ebuild?r1=1.7&r2=1.8
Comment 1 Julian Ospald 2013-09-26 12:25:52 UTC
once the failed fetch has been done, the user has to remove the directory in git3-src/ manually before a non-shallow clone can work
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-09-26 12:39:42 UTC
It's not my fault if people commit stuff without testing. I think that I explicitly mentioned Google Code in most of my mails about it, and I've just updated the docstring to make that clear.
Comment 3 Julian Ospald 2013-09-26 12:42:51 UTC
That proves that your eclass DEFAULT is not sane.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-09-26 12:49:00 UTC
No. It only proves that Google can't sustain a compliant git server. Default is supposed to represent the *most common* case. Then, you can disable them per-ebuild as necessary. Going the other way is not that simple.
Comment 5 Rick Farina (Zero_Chaos) gentoo-dev 2013-11-14 18:22:58 UTC
Is it really sane to shallow by default and expect people to disable it on "non-compliant git servers"?  this also seems to break on local shallow checkouts as it tries to write to the repo (???)

 * Fetching HEAD from /home/eroen/projects/git-annex-wrapper ...
git fetch --no-tags /home/eroen/projects/git-annex-wrapper --depth 1 -f HEAD:dev-python/ga_wrapper/0/__main__
 * ACCESS DENIED:  mkstemp64:    /home/eroen/projects/git-annex-wrapper/.git/shallow_XXXXXX
fatal: Unable to create temporary file '/home/eroen/projects/git-annex-wrapper/.git/shallow_XXXXXX': Permission denied
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-11-14 18:27:01 UTC
(In reply to Rick Farina (Zero_Chaos) from comment #5)
> Is it really sane to shallow by default and expect people to disable it on
> "non-compliant git servers"?

It is better than expecting people to enable it globally and then disable per-package on packages that got broken.

>  this also seems to break on local shallow
> checkouts as it tries to write to the repo (???)
> 
>  * Fetching HEAD from /home/eroen/projects/git-annex-wrapper ...
> git fetch --no-tags /home/eroen/projects/git-annex-wrapper --depth 1 -f
> HEAD:dev-python/ga_wrapper/0/__main__
>  * ACCESS DENIED:  mkstemp64:   
> /home/eroen/projects/git-annex-wrapper/.git/shallow_XXXXXX
> fatal: Unable to create temporary file
> '/home/eroen/projects/git-annex-wrapper/.git/shallow_XXXXXX': Permission
> denied

Please report a bug.
Comment 7 Rick Farina (Zero_Chaos) gentoo-dev 2013-11-14 19:24:44 UTC
(In reply to Michał Górny from comment #6)
> Please report a bug.

486074
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-02-20 22:38:51 UTC
The eclass is going to get non-shallow support removed so we can close this.