Bug 485604 – texlive-module.eclass: please review prefix changes

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Christoph Junghans (RETIRED) 2013-09-21 18:32:54 UTC]

Created attachment 359196 [details, diff]
patch against gx86

${D} -> ${ED} nothing more.

[Comment 1 Alexis Ballier 2013-09-22 12:22:17 UTC]

Comment on attachment 359196 [details, diff]
patch against gx86

>--- /usr/portage/eclass/texlive-module.eclass	2013-07-05 17:01:17.000000000 -0600
>+++ texlive-module.eclass	2013-09-21 12:29:39.475089593 -0600
>@@ -306,21 +306,22 @@
> # Installs texmf and config files to the system.
> 
> texlive-module_src_install() {
>+	has "${EAPI:-0}" 0 1 2 && ! use prefix && ED="${D}"

same as for -common: better bump eapi requirement

rest looks ok

[Comment 2 Christoph Junghans (RETIRED) 2013-09-25 01:27:29 UTC]

Created attachment 359400 [details, diff]
patch against gx86

It seems, there is no consumer with EAPI<3

$ for i in $(find /usr/portage -name "*.ebuild" -exec grep inherit.*texlive-module {} + | sed 's/:.*//'); do echo $i EAPI: $(grep EAPI $i); done

So here is an improved patch.

[Comment 3 Alexis Ballier 2013-09-25 15:02:06 UTC]

(In reply to Christoph Junghans from comment #2)
> Created attachment 359400 [details, diff] [details, diff]
> patch against gx86
> 

looks very good to me, please commit, thanks!

[Comment 4 Christoph Junghans (RETIRED) 2013-09-25 15:18:43 UTC]

+  25 Sep 2013; Christoph Junghans <[e-mail]> texlive-module.eclass:
+  Require EAPI>=2, add prefix support
+