Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 485196 - net-im/prosody-0.9.2 - readd systemd unit
Summary: net-im/prosody-0.9.2 - readd systemd unit
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Rafael Martins (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: install-systemd-unit
  Show dependency tree
 
Reported: 2013-09-17 14:27 UTC by Alexander Tsoy
Modified: 2015-02-27 21:19 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
prosody.service-r1 (prosody.service-r1,192 bytes, text/plain)
2013-09-17 14:27 UTC, Alexander Tsoy
Details
prosody-0.9.1-r1.ebuild.patch (prosody-0.9.1-r1.ebuild.patch,571 bytes, patch)
2013-09-17 14:35 UTC, Alexander Tsoy
Details | Diff
prosody.service.diff (prosody.service.diff,408 bytes, patch)
2013-09-17 14:37 UTC, Alexander Tsoy
Details | Diff
prosody.tmpfilesd (prosody.tmpfilesd,39 bytes, text/plain)
2014-01-29 13:07 UTC, Alexander Tsoy
Details
prosody-0.9.2.ebuild.patch (prosody-0.9.2.ebuild.patch,851 bytes, patch)
2014-01-29 13:11 UTC, Alexander Tsoy
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Tsoy 2013-09-17 14:27:24 UTC
Created attachment 358856 [details]
prosody.service-r1

Please add systemd unit.

Old unit works well with prosody-0.9, but this one is better.
Comment 1 Alexander Tsoy 2013-09-17 14:35:36 UTC
Created attachment 358858 [details, diff]
prosody-0.9.1-r1.ebuild.patch

tmpfiles.d config is not needed anymore.
Comment 2 Alexander Tsoy 2013-09-17 14:37:19 UTC
Created attachment 358860 [details, diff]
prosody.service.diff

diff between old and new units
Comment 3 Pacho Ramos gentoo-dev 2013-09-17 19:13:19 UTC
(The package already includes systemd unit files, it shouldn't block the bug for adding them then)
Comment 4 Alexander Tsoy 2013-10-09 15:35:48 UTC
(In reply to Pacho Ramos from comment #3)
> (The package already includes systemd unit files, it shouldn't block the bug
> for adding them then)

Actually systemd support was removed from prosody-0.9*
Comment 5 Alexander Tsoy 2014-01-29 13:07:17 UTC
Created attachment 369054 [details]
prosody.tmpfilesd

Default prosody.cfg.lua has been changed in prosody-0.9.2:
- "pidfile" option was added, that's why tmpfiles.d config is needed. prosody fails to start if it can't write PID file
- "daemonize = true" option causes warnings in log:
Jan 29 16:23:53 mod_posix       error   Failed to daemonize: already-daemonized

I'm not sure what to do with the last issue. Two options here:
1. use old systemd unit with Type=forking and prosodyctl
2. leave it up to the users to ignore warnings or to change "daemonize" option in config.
Comment 6 Alexander Tsoy 2014-01-29 13:11:18 UTC
Created attachment 369056 [details, diff]
prosody-0.9.2.ebuild.patch
Comment 7 Mike Gilbert gentoo-dev 2014-01-30 03:42:33 UTC
(In reply to Alexander Tsoy from comment #4)
> Actually systemd support was removed from prosody-0.9*

Yeah, if it got dropped we should block the tracker again.
Comment 8 Pacho Ramos gentoo-dev 2014-02-02 12:09:42 UTC
That "daemonize = true" was added on purpose in our patch to make it fit the openrc init.d script... maybe we could add a systemd USE flag to provide a different config that fits better systemd unit file and let us drop the pid handling... or use the old unit file.

@systemd team, what do you prefer? (I personally like much more to avoid "forking", but that is only my opinion)
Comment 9 Andrius Štikonas 2015-02-27 18:17:20 UTC
Looks like the bug was fixed. Please close it...