Bug 482646 – gnome2.eclass: pass proper --docdir="${EPREFIX}"/usr/share/doc/${PF}

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Pacho Ramos 2013-08-27 08:46:41 UTC]

From time to time we get reports about gnome2.eclass users not installing in proper location. I think we should do the same as autotools-utils.eclass is doing:
        if "${ECONF_SOURCE}"/configure --help 2>&1 | grep -q '^ *--docdir='; then
                econfargs+=(
                        --docdir="${EPREFIX}"/usr/share/doc/${PF}
                )
        fi

[Comment 1 Gilles Dartiguelongue (RETIRED) 2013-08-27 21:45:28 UTC]

Any example of package not complying ?

[Comment 2 Pacho Ramos 2013-08-28 08:06:55 UTC]

For now I see anjuta, bless, entangle, muine and osm-gps-map appending it. But I noticed this when reviewing our list of assigned bugs and seeing bug 443950. 

Then, I thought that would be better to fix it at eclass level to prevent we needing to wait for people reporting this kind of problems and we fixing them per ebuild

[Comment 3 Gilles Dartiguelongue (RETIRED) 2013-09-02 22:03:35 UTC]

FTR, I have postinst hooks that detect this kind of problem.

[Comment 4 Pacho Ramos 2013-09-03 06:02:51 UTC]

I am unsure if relying on every dev using gnome2.eclass making use of that hook to know when to append the option to their ebuild :|

Also, since (on Gentoo, even if I still don't see much advantage of having that rule), we need to set docdir to that location, I think would be better to set it to that by default

[Comment 5 Gilles Dartiguelongue (RETIRED) 2013-09-03 21:43:55 UTC]

I wonder how that affects packages providing gtk-doc.
Also, this would imply we need to cleanup some packages doing dodoc because it would install docs twice, right ?

[Comment 6 Pacho Ramos 2013-09-03 21:50:19 UTC]

(In reply to Gilles Dartiguelongue from comment #5)
> I wonder how that affects packages providing gtk-doc.

Will need to check this as I don't know if gtk-doc follows this switch

> Also, this would imply we need to cleanup some packages doing dodoc because
> it would install docs twice, right ?

No, dodoc is already installing that files in the proper localization:
/usr/lib64/portage/bin/ebuild-helpers/dodoc
dir="${ED}usr/share/doc/${PF}/${_E_DOCDESTTREE_}"
if [ ! -d "${dir}" ] ; then
        install -d "${dir}"
fi

[Comment 7 Pacho Ramos 2013-09-03 21:56:01 UTC]

I think gtk-doc is handled in a different way, look for example to goffice:
- docdir defaults to /usr/share/doc/goffice 
- gtk-doc are still being installed in /usr/share/gtk-doc/

Reading gtk-doc.m4 looks like it follows --with-html-dir:
    AS_HELP_STRING([--with-html-dir=PATH], [path to installed docs]),,
    [with_html_dir='${datadir}/gtk-doc/html'])

[Comment 8 Pacho Ramos 2013-09-29 07:25:47 UTC]

And then? :/

[Comment 9 Pacho Ramos 2013-12-27 11:07:04 UTC]

(as talked on IRC)

[Comment 10 Pacho Ramos 2014-02-11 21:13:27 UTC]

*** Bug 501018 has been marked as a duplicate of this bug. ***

[Comment 11 Pacho Ramos 2014-02-11 21:14:24 UTC]

+  11 Feb 2014; Pacho Ramos <[e-mail]> gnome2.eclass:
+  Pass --docdir with proper directory, bug #482646
+