Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 481980 - [Future EAPI] Consider that DOCS variable can contain directories
Summary: [Future EAPI] Consider that DOCS variable can contain directories
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: PMS/EAPI (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Package Manager Specification
URL:
Whiteboard: in-eapi-6
Keywords:
Depends on:
Blocks: future-eapi
  Show dependency tree
 
Reported: 2013-08-21 15:20 UTC by Sergey Popov (RETIRED)
Modified: 2015-11-08 21:58 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Popov (RETIRED) gentoo-dev 2013-08-21 15:20:32 UTC 
See $summary. It would be nice to do such assumption, e.g. do dodoc -r instead of just dodoc in default src_install phase
Comment 2 Tiziano Müller (RETIRED) gentoo-dev 2014-06-05 07:30:11 UTC 
Would it make sense to introduce "rsync-syntax" here as in:

  DOCS="directory/" does the same as "dodoc -r directory/*"
  DOCS="directory" does the same as "dodoc -r directory"
Comment 3 Ulrich Müller gentoo-dev 2014-06-05 08:20:29 UTC 
(In reply to Tiziano Müller from comment #2)
> Would it make sense to introduce "rsync-syntax" here as in:
> 
>   DOCS="directory/" does the same as "dodoc -r directory/*"
>   DOCS="directory" does the same as "dodoc -r directory"

I'd rather not, especially since the interpretation of trailing slashes has changed in POSIX.1-2008, insofar as "directory/" is no longer defined as being equivalent to "directory/." (as it still was in POSIX.1-2004).

AFAICS, an explicit DOCS="directory/." should work for the first case above.
Comment 4 Tiziano Müller (RETIRED) gentoo-dev 2014-06-05 08:35:14 UTC 
(In reply to Ulrich Müller from comment #3)
> I'd rather not, especially since the interpretation of trailing slashes has
> changed in POSIX.1-2008, insofar as "directory/" is no longer defined as
> being equivalent to "directory/." (as it still was in POSIX.1-2004).
> 
> AFAICS, an explicit DOCS="directory/." should work for the first case above.

well, DOCS="directory/." is ok as well, as long as we have a way to express "dodoc directory/*" somehow.