Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 480188 - sys-libs/ncurses: multilib conversion
Summary: sys-libs/ncurses: multilib conversion
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: gx86-multilib
  Show dependency tree
 
Reported: 2013-08-07 17:49 UTC by Alexis Ballier
Modified: 2013-08-21 15:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild diff (ncurses-multilib.patch,5.02 KB, patch)
2013-08-07 17:49 UTC, Alexis Ballier
Details | Diff
the ebuild itself (ncurses-5.9-r3.ebuild,6.25 KB, text/plain)
2013-08-07 17:50 UTC, Alexis Ballier
Details
ebuild diff (ncurses-multilib.patch,5.17 KB, patch)
2013-08-08 14:13 UTC, Alexis Ballier
Details | Diff
the ebuild itself (ncurses-5.9-r3.ebuild,6.22 KB, text/plain)
2013-08-08 14:13 UTC, Alexis Ballier
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Ballier gentoo-dev 2013-08-07 17:49:14 UTC
Created attachment 355360 [details, diff]
ebuild diff

needs gpm, has missing blockers on emul-libs: will enter the tree masked and get proper blockers upon unmasking

please review carefuly as this one is non trivial
Comment 1 Alexis Ballier gentoo-dev 2013-08-07 17:50:03 UTC
Created attachment 355362 [details]
the ebuild itself

might be easier to read that way
Comment 2 Pacho Ramos gentoo-dev 2013-08-08 07:00:52 UTC
Maybe patches stuff from src_unpack should be moved to src_prepare ;)
Comment 3 Alexis Ballier gentoo-dev 2013-08-08 14:13:24 UTC
Created attachment 355412 [details, diff]
ebuild diff

right, fixed

also moved the tc-export & friends to the right place (src_configure vs multilib_src_configure) and reordered the function definitions in an imho more natural way
Comment 4 Alexis Ballier gentoo-dev 2013-08-08 14:13:56 UTC
Created attachment 355414 [details]
the ebuild itself
Comment 5 Alexis Ballier gentoo-dev 2013-08-11 01:00:06 UTC
maybe we could move the gpm[multilib_usedep] dep to PDEPEND to try to avoid circular deps with gpm since its dlopened. opinions?
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-08-11 07:28:23 UTC
(In reply to Alexis Ballier from comment #5)
> maybe we could move the gpm[multilib_usedep] dep to PDEPEND to try to avoid
> circular deps with gpm since its dlopened. opinions?

We can't. Even with --with-dlsym, the code still does some checks on the headers and library.
Comment 7 Alexis Ballier gentoo-dev 2013-08-14 18:01:50 UTC
ping @maintainers: I will commit this in a few days unless you state here you want a "delay" for reviewing.
Comment 8 Alexis Ballier gentoo-dev 2013-08-21 15:58:35 UTC
in cvs

gpm moved to pdepend and --with-gpm=libgpm.so.1 works without multilib gpm for non native abis.