Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 479310 - sys-apps/attr: Multilib conversion
Summary: sys-apps/attr: Multilib conversion
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 479282
  Show dependency tree
 
Reported: 2013-07-31 19:16 UTC by Alexis Ballier
Modified: 2013-08-10 13:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild diff (attr-multilib.patch,1.33 KB, patch)
2013-07-31 19:16 UTC, Alexis Ballier
Details | Diff
ebuild diff (attr-multilib.patch,1.29 KB, patch)
2013-08-09 12:54 UTC, Alexis Ballier
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Ballier gentoo-dev 2013-07-31 19:16:02 UTC
Created attachment 354756 [details, diff]
ebuild diff

This would enter the tree masked and will get the relevant blockers on emul-libs upon unmasking.
Comment 1 SpanKY gentoo-dev 2013-08-08 16:25:18 UTC
Comment on attachment 354756 [details, diff]
ebuild diff

>@@ -26,9 +26,10 @@
> 		include/builddefs.in \
> 		|| die
> 	strip-linguas -u po
>+	multilib_copy_sources

why ?  does the package not build out-of-tree ?  if it doesn't, let's fix that instead.

>+multilib_src_compile() {
>+	local mopts=""
>+	multilib_is_native_abi || mopts="TOOL_SUBDIRS= "
>+	emake ${mopts}

i'd one-line it:

 emake $(multilib_is_native_abi || echo TOOL_SUBDIRS=)

>+multilib_src_install() {
>+	local mopts=""
>+	multilib_is_native_abi || mopts="TOOL_SUBDIRS= "
>+	emake ${mopts} DIST_ROOT="${D}" install install-lib install-dev

same here, although you prob want to start wrapping the args

 emake \
    ...tool subdirs... \
    DIST_ROOT... \
    ...install targets...
Comment 2 Alexis Ballier gentoo-dev 2013-08-08 16:48:12 UTC
(In reply to SpanKY from comment #1)
> Comment on attachment 354756 [details, diff] [details, diff]
> ebuild diff
> 
> >@@ -26,9 +26,10 @@
> > 		include/builddefs.in \
> > 		|| die
> > 	strip-linguas -u po
> >+	multilib_copy_sources
> 
> why ?  does the package not build out-of-tree ?  if it doesn't, let's fix
> that instead.


checking whether x86_64-pc-linux-gnu-gcc -m32 accepts -g... (cached) yes
checking for x86_64-pc-linux-gnu-gcc -m32 option to accept ISO C89... (cached) none needed
/var/tmp/portage/sys-apps/attr-2.4.47-r1/work/attr-2.4.47/configure: line 11183: ./VERSION: No such file or directory

!!! Please attach the following file when seeking support:
!!! /var/tmp/portage/sys-apps/attr-2.4.47-r1/work/attr-2.4.47-x86/config.log
 * ERROR: sys-apps/attr-2.4.47-r1::gentoo failed (configure phase):



configure is: 
#! /bin/sh
# Guess values for system-dependent variables and create Makefiles.
# Generated by GNU Autoconf 2.69.
#
#

but there is no configure.ac/in

do you really want this to be patched ?

even if I copy that VERSION file, its not automake based and configure only generates include/{builddefs,config.h} + libtool

------

fixed the rest locally
Comment 3 Alexis Ballier gentoo-dev 2013-08-09 12:54:13 UTC
Created attachment 355484 [details, diff]
ebuild diff

updated patch

out of tree builds really do not work. I filled https://savannah.nongnu.org/bugs/index.php?39736
IMHO its not worth fixing for now.


I'll commit if you have no more objection, glib has been acked by its maintainers and this is the only remaining blocker.
Comment 4 Alexis Ballier gentoo-dev 2013-08-10 13:41:20 UTC
(In reply to Alexis Ballier from comment #3)
> Created attachment 355484 [details, diff] [details, diff]
> ebuild diff
> 
> updated patch
> 
> out of tree builds really do not work. I filled
> https://savannah.nongnu.org/bugs/index.php?39736
> IMHO its not worth fixing for now.
> 
> 
> I'll commit if you have no more objection, glib has been acked by its
> maintainers and this is the only remaining blocker.

committed (masked atm)