Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 478706 - app-arch/p7zip-9.20.1-r3 USE=kde - desktop files have category entry set as icon entry
Summary: app-arch/p7zip-9.20.1-r3 USE=kde - desktop files have category entry set as i...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Justin Lecher (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 477180
  Show dependency tree
 
Reported: 2013-07-30 00:21 UTC by Shubhadeep Chaudhuri
Modified: 2013-09-19 13:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shubhadeep Chaudhuri 2013-07-30 00:21:28 UTC 
This package creates two desktop files called 7zFM-p7zip.desktop and 7zG-p7zip.desktop which don't show any icons.
It seems what should have been the category is set as the value for icon. Please check and fix.
Comment 1 Justin Lecher (RETIRED) gentoo-dev 2013-08-01 06:28:53 UTC 
Thanks for spotting this.

+*p7zip-9.20.1-r4 (01 Aug 2013)
+
+  01 Aug 2013; Justin Lecher <jlec@gentoo.org> -p7zip-9.20.1-r3.ebuild,
+  +p7zip-9.20.1-r4.ebuild, metadata.xml:
+  Fix icon in desktop file, #478706
+
Comment 2 Shubhadeep Chaudhuri 2013-08-01 07:45:45 UTC 
Why use an absolute path for the icon? Just specifying the name will also make it compatible with icon themes.
Comment 3 Justin Lecher (RETIRED) gentoo-dev 2013-08-01 08:27:34 UTC 
Are you sure it find the icon in the one subfolder? Because we only have one size.
Comment 4 Shubhadeep Chaudhuri 2013-08-01 08:47:03 UTC 
Yes. To be sure, I just tested your ebuild with just p7zip as the icon entry instead of the absolute paths. It used the 16x16 icon for every size.
Comment 5 Justin Lecher (RETIRED) gentoo-dev 2013-08-01 08:50:48 UTC 
+  01 Aug 2013; Justin Lecher <jlec@gentoo.org> p7zip-9.20.1-r4.ebuild:
+  Drop full path from icon
+
Comment 6 Martin Walch 2013-09-19 13:21:48 UTC 
This now leads to a warning:

 * As described in the Icon Theme Specification, icon file extensions are not
 * allowed in .desktop files if the value is not an absolute path.
Comment 7 Justin Lecher (RETIRED) gentoo-dev 2013-09-19 13:27:25 UTC 
+  19 Sep 2013; Justin Lecher <jlec@gentoo.org> p7zip-9.20.1-r4.ebuild,
+  p7zip-9.20.1-r5.ebuild:
+  Drop icon extention from icon file, #478706
+