Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 47870 - net-www/mozilla-firefox-0.8-r2 fails to compile with gcc 3.4
Summary: net-www/mozilla-firefox-0.8-r2 fails to compile with gcc 3.4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GCC Porting (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Please assign to toolchain
URL:
Whiteboard:
Keywords:
: 49049 (view as bug list)
Depends on:
Blocks: 48528
  Show dependency tree
 
Reported: 2004-04-14 18:24 UTC by Tim
Modified: 2004-04-27 21:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Diff file that edits line 237 (gcc-3.4-mozilla-firefox.diff,664 bytes, patch)
2004-04-14 18:26 UTC, Tim 		Details | Diff
Updated patch to fix GCC 3.4 compilation error (mozilla-thunderbird-0.5-gcc34.patch,460 bytes, patch)
2004-04-22 18:39 UTC, Robert Moss (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim 2004-04-14 18:24:09 UTC 
Attatched is a fix for it.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Tim 2004-04-14 18:26:13 UTC 
Created attachment 29301 [details, diff]
Diff file that edits line 237
Comment 2 Tim 2004-04-14 18:35:37 UTC 
Compile error declared privateduring compile added public: on line 237 tested firefox works fine with it
Comment 3 Tim 2004-04-14 18:37:05 UTC 
Compile error declared privateduring compile added public: on line 237 tested firefox works fine with it
Comment 4 Tim 2004-04-14 18:37:31 UTC 
Compile error declared privateduring compile added public: on line 237 tested firefox works fine with it
Comment 5 Chris Brown 2004-04-16 02:42:23 UTC 
Is the diff file correct?
It adds public to the first line and comments out the second line?
Comment 6 Robert Moss (RETIRED) gentoo-dev 2004-04-22 18:37:27 UTC 
The diff is not correct. The second line should not be commented. I can't upload a new patch as I'm using Lynx - well I'll try... :-P
Comment 7 Robert Moss (RETIRED) gentoo-dev 2004-04-22 18:39:44 UTC 
Created attachment 29865 [details, diff]
Updated patch to fix GCC 3.4 compilation error

The second line should not be commented.

If this works it's my first ever Lynx-submitted patch :-D
Comment 8 Robert Moss (RETIRED) gentoo-dev 2004-04-22 18:47:20 UTC 
I couldn't obsolete the other patch with Lynx - sorry.
Comment 9 Aron Griffis (RETIRED) gentoo-dev 2004-04-26 11:34:36 UTC 
I've fixed this in mozilla-firefox-0.8-r3.ebuild and mozilla-1.6-r1.ebuild.  It doesn't seem to apply to mozilla-thunderbird-0.5-r1 or to mozilla-1.7, hope it's not needed there.  Thanks!
Comment 10 Aron Griffis (RETIRED) gentoo-dev 2004-04-26 15:47:53 UTC 
*** Bug 49049 has been marked as a duplicate of this bug. ***
Comment 11 Andrew Sayman 2004-04-27 18:34:26 UTC 
This bug does affect mozilla-thunderbird-0.5-r1
Comment 12 Robert Moss (RETIRED) gentoo-dev 2004-04-27 21:04:57 UTC 
This fix is not needed for Mozilla 1.7*, but IS needed for Mozilla Thunderbird 0.5*.